Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag to control gix transport impl #62

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DCjanus
Copy link

@DCjanus DCjanus commented May 12, 2024

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

The crate gix provides two features, blocking-http-transport-reqwest and blocking-http-transport-curl, but they cannot be set simultaneously.

Most of the time, this requirement is easy to meet, unless we depend on multiple crates that have chosen different features.

In deps.rs, we encountered this problem:

  • deps.rs -> rustsec -> tame-index -> gix/blocking-http-transport-reqwest
  • deps.rs -> crates-index -> gix/blocking-http-transport-curl

Perhaps we should expose two features: gix-curl and gix-reqwest, so that upper-level users can have more fine-grained control.

@DCjanus DCjanus requested a review from Jake-Shadle as a code owner May 12, 2024 04:18
@Jake-Shadle
Copy link
Member

It's not allowing me to push to your fork despite it saying so, please fix the issues if you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants