Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable clippy warning #129

Merged
merged 2 commits into from Jan 23, 2024
Merged

Disable clippy warning #129

merged 2 commits into from Jan 23, 2024

Conversation

fornwall
Copy link
Contributor

Disable the clippy warning giving the below error:

error: variant name ends with the enum's name
--> crates/mirror-mirror/src/tests/meta.rs:57:5
|
57 | C,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
= note: -D clippy::enum-variant-names implied by -D warnings
= help: to override -D warnings add #[allow(clippy::enum_variant_names)]

Disable the clippy warning giving the below error:

error: variant name ends with the enum's name
  --> crates/mirror-mirror/src/tests/meta.rs:57:5
   |
57 |     C,
   |     ^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
   = note: `-D clippy::enum-variant-names` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::enum_variant_names)]`
@davidpdrsn
Copy link
Member

I just merged two other PRs so wanna merge main and see if that fixes CI? I think it should 🤞

@fornwall
Copy link
Contributor Author

fornwall commented Jan 19, 2024

Done!

The remaining failure is for cargo build --target thumbv6m-none-eabi --no-default-features:

error[E0599]: no method named compare_exchange found for struct portable_atomic::AtomicPtr in the current scope
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/once_cell-1.19.0/src/race.rs:348:39

Should be fixed by #131

@davidpdrsn davidpdrsn merged commit 52f2a84 into main Jan 23, 2024
4 of 5 checks passed
@davidpdrsn davidpdrsn deleted the disable-clippy-warning branch January 23, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants