Skip to content

Commit

Permalink
Fix cfg issues (#83)
Browse files Browse the repository at this point in the history
* Fix dependency pairing

We we were ignoring the cfg of the dependency when locating the krate dependency for a resolved node

* Fix additional issue

Noticed this when adding the new test case, if not filtering targets then expressions that could never evaluate to true were causing graph inclusion

* Fix lint

* Fix deny

* Update CHANGELOG
  • Loading branch information
Jake-Shadle committed Apr 11, 2024
1 parent 5fb45eb commit 0ffe190
Show file tree
Hide file tree
Showing 11 changed files with 1,568 additions and 21 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Expand Up @@ -8,6 +8,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

<!-- next-header -->
## [Unreleased] - ReleaseDate
### Fixed
- [PR#83](https://github.com/EmbarkStudios/krates/pull/83) resolved [#82](https://github.com/EmbarkStudios/krates/issues/82) by properly handling `cfg()` specific dependencies for the same crate with different features enabled.
- [PR#83](https://github.com/EmbarkStudios/krates/pull/83) fixed an issue where `cfg(any())` crates would be pulled into the graph erroneously if not performing target filtering.

## [0.16.9] - 2024-04-09
### Fixed
- [PR#81](https://github.com/EmbarkStudios/krates/pull/81) re-resolved [#79](https://github.com/EmbarkStudios/krates/issues/79) because the PR#80 completely broke in the presence of cargo patches.
Expand Down

0 comments on commit 0ffe190

Please sign in to comment.