Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to rustls #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Switch back to rustls #6

wants to merge 1 commit into from

Conversation

fornwall
Copy link

@fornwall fornwall commented Jan 25, 2024

Switch back to rustls, as the linked issue kube-rs/kube#153 that the comment indicates is a blocker has been resolved.

Motivation is to avoid pain points when building openssl-sys on Windows (ping @jnises, who had some bad perl installation on Windows that didn't work).

NOTE: Not tested - can you test (let me know otherwise)?

Bumped several dependencies to get rid of some duplicates - let me know if that should be split to a separate PR.

@fornwall fornwall marked this pull request as ready for review January 25, 2024 12:14
@jnises
Copy link
Member

jnises commented Jan 30, 2024

Any progress on this?

@Jake-Shadle
Copy link
Member

I'm working on something else and have no time for this, if you confirm it works in ark I can merge and release.

@jnises
Copy link
Member

jnises commented Jan 30, 2024

I'm working on something else and have no time for this, if you confirm it works in ark I can merge and release.

It compiles without errors.
And ./bark validate works now.

@Jake-Shadle
Copy link
Member

That doesn't exercise the changed code.

@jnises
Copy link
Member

jnises commented Jan 30, 2024

That doesn't exercise the changed code.

How do I best exercise the code?

@Jake-Shadle
Copy link
Member

I guess I just don't understand the urgency of this issue when there is a pre-built Windows binary if you are unable to compile it from source.

@jnises
Copy link
Member

jnises commented Jan 31, 2024

I guess I just don't understand the urgency of this issue when there is a pre-built Windows binary if you are unable to compile it from source.

I see now in the bark code that it tries to download a pre-built binary. I guess that fails for some reason, so it falls back to compiling it.
Downloading the prebuilt binary and updating PATH solves the problem for me.
Thanks :)

@fredr fredr removed their request for review April 19, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants