Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen ash support up to 0.37, and bump version to 0.13.1. #71

Merged
merged 2 commits into from Oct 4, 2022

Conversation

eddyb
Copy link
Contributor

@eddyb eddyb commented Oct 4, 2022

As explained in the comment left in Cargo.toml, we can support multiple (otherwise "breaking") versions of ash, because very little of ash's API surface is being interfaced with.

I've tested the code with ash at 0.35, 0.36, 0.37 and they all pass cargo check, but I don't have a macOS system to test that it actually runs - still, the API is so simple I can't imagine it breaking in a subtle way.

Since this is backwards-compatible, I've only bumped the patch number in ash-molten's version, and we can continue to do so in the future to support more ash versions.

Something I'm not sure about is: should CI try all supported ash versions to avoid regressing?


As for why I need this: bumping wgpu in Rust-GPU, for example-runner-wgpu, requires ash 0.37, and ash-molten was keeping example-runner-ash on ash 0.35, leading to two builds of ash (it's not the only cause of build duplication, but it was getting in the way).

With this PR, I can unify those dependencies quite nicely (though, again, can't actually test native functionality on macOS).


Also, whoever lands this PR should publish the new version (I don't think I have the power to, but also I'd rather not touch that part).

@eddyb
Copy link
Contributor Author

eddyb commented Oct 4, 2022

Interesting, looks like the proc macro ecosystem now requires Unicode-DFS-2016 (via unicode-ident).
That seems harmless but I am very much not a lawyer. For the record this is the PR adding it:

And you can see below that all the repos using cargo-deny which have had to allow the new license.

Copy link
Contributor

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yeah, that's how I intended this to be used. Allows ash-molten to do a simple patch release as well as long as the lower bound for ash doesn't change 🎉

@mergify mergify bot merged commit 3987210 into EmbarkStudios:main Oct 4, 2022
@eddyb eddyb deleted the ash-0.37 branch October 4, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants