Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitcoin: bump 0.28.0 -> 0.29.1 #147
bitcoin: bump 0.28.0 -> 0.29.1 #147
Changes from all commits
730072f
5304cde
a43e090
7a53252
6039cc4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to docs StdRng use ChaCha, I think it's equivalent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as it's deterministic anything should work here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've errors in examples in comparison against test vectors (
pset_blind_coinjoin.rs
andraw_blind.rs
) which I think it's because those are not equivalent...I can't keep rand 0.6 because it would break against secp256k1_zkp which is now 0.8
Any suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can look into finding an equivalent here. 0.8 rand should have some equivalent PRNG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a deprecation notice on rand 0.6 referring to using the
rand_chacha
crate (luckily wee need only as dev-dep), I tested it and it looks compatible:So I added c187bbb
and
raw_blind.rs
example works, however,pset_blind_coinjoin.rs
still doesn't!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm tempted to add a commit which removes the
rand_chacha
dep, sticks in some custom crappy RNG, and updates the test vectors. We'd still have a commit that usedrand_chacha
so that readers could check that the change in tests was only due to the change in RNG, rather than anything else.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe that should just be a separate PR..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#148
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI this was due to wrongdoing in the "fix warning" commit