Taproot Support #111
Merged
Taproot Support #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit only adds the support for taproot signature hash from bitcoin. For elements, BIP341 is ammended as described in doc/taphash.md. For ease of review, elements specific changes would be done in the following commit
apoelstra
reviewed
Jan 3, 2022
apoelstra
reviewed
Jan 3, 2022
Note this code does not compile. This commit only meant for aiding in review. This will be squashed with the subsequent commit that fixes other bugs and implements elements specific logic later taptweaking code fixup Make copied code compile
|
@apoelstra , squashed. All commits should compile now. |
apoelstra
approved these changes
Jan 4, 2022
|
cc @sanket1729 is this ready to go? You mentioned it to me on a recent call but it looks like it's already ACKed. Do you just want me to merge it? |
|
Yes, this is ready to go. I can merge it. |
sanket1729
added a commit
that referenced
this pull request
May 18, 2022
35110f6 Add utility methods for fetching sighash types from inputs (sanket1729) a860698 Add #[test] to unused test (sanket1729) f429873 Rename SigHashType to EcdsaSighashType (sanket1729) f02eedc Remove std feature (sanket1729) 8f65c48 Add Support for Psbt Sighash type (sanket1729) Pull request description: Also adds FromStr/Display for SchnorrSignatureHashType - The first commit adds PsbtSighashType(needed for schnorr sigh psbt support) - The second commit fixes a bug introduced in copy-pasting during the #111. - The third commit does renaming to distinguish SchnorrSigHashType and EcdsaSigHashType - The last and fourth commit fixes a small nit by adding a #[test] to untested code in serde feature. ACKs for top commit: apoelstra: ACK 35110f6 Tree-SHA512: 269a10e34bc930de6238a104c7494e56bcb7e68507d194b18a49c612c85c77bf5b5c12a22b43fb467666e3726d178fdfc8564ec1e73881845fd48dc5c1b46155
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits 86979bc and 16ba676 don't compile. They are only separated for review aid. These commits have code that is copied from rust-bitcoin, and the subsequent commits make the elements specific changes which should be easy to review.
After this is ready for merge, I will squash the non-compiling commits to have a good history.
The last commit has integration tests for sighash/taproot tests for elements