make lwk available #288

YusukeShimizu · 2024-03-11T00:50:52Z

lbtc swap with lwk

Description

Previously, lbtc swap required running elementsd, but now it can be done with lwk.
Because elementsd requires a lot of resources, making it available in lwk will allow more users to perform swaps.

setup

see docs/setup_lwk.md.

Specification

lwk and esplora-electrs connection is required.
New json rpc api client is implemented for connection to lwk.

Connection to esplora-electrs using go-electrum.
esplora-electrs is also used by lwk as a blockchain.

Configuration

The user can choose to use lwk instead of elements for lbtc swap.
It has the following configuration items.

type LWKConf struct {
	SignerName       string
	WalletName       string
	LWKEndpoint      string
	ElementsEndpoint string
	Network          string
	LiquidSwaps      *bool
}

The user can choose to set up a wallet that holds the signer.
Default uses the same default endpoint (blockstream.info:995) as lwk, but the user can choose his own electrum for ElementsEndpoint.

wallet

Peerswap's onchain wallet provide the following features.

type Wallet interface {
	GetAddress() (string, error)
	SendToAddress(string, uint64) (string, error)
	GetBalance() (uint64, error)
	CreateAndBroadcastTransaction(swapParams *swap.OpeningParams, asset []byte) (txid, rawTx string, fee uint64, err error)
	SendRawTx(rawTx string) (txid string, err error)
	GetFee(txSize int64) (uint64, error)
}

GetAddress() (string, error)

This method is used to get the address of the wallet.
Use lwk address.

SendToAddress(string, uint64) (string, error)

This method is used to send money to a specific address.
lwk send to create a psbt, sign to sign it, and broadcast to broadcast it.

CreateAndBroadcastTransaction(swapParams *swap.OpeningParams, asset []byte) (txid, rawTx string, fee uint64, err error)

This method is used to create and broadcast opening tx.
The interface has been split into the following two interfaces,
but they will be merged into a single interface for lwk support.
Existing bitcoin wallets will also be changed, but functionality will remain the same.

CreateFundedTransaction(preparedTx *transaction.Transaction) (rawTx string, fee uint64, err error)
FinalizeFundedTransaction(unpreparedTx string) (preparedTxHex string, err error)

SendRawTx(rawTx string) (txid string, err error)

This method is used to broadcast the closing tx.
This is done using electrum cient's blockchain.transaction.broadcast method.

GetFee(txSize int64) (uint64, error)

This method is used to get the fee blockchain.estimatefee.

tx watcher

tx watcher is a function that monitors onchain status and notifies opening tx and closing tx.
The following interface must be implemented.

type TxWatcher interface {
	AddWaitForConfirmationTx(swapId, txId string, vout, startingHeight uint32, scriptpubkey []byte)
	AddWaitForCsvTx(swapId, txId string, vout uint32, startingHeight uint32, scriptpubkey []byte)
	AddConfirmationCallback(func(swapId string, txHex string, err error) error)
	AddCsvCallback(func(swapId string) error)
	GetBlockHeight() (uint32, error)
	StartWatchingTxs() error
}

So far, peerswap has used bitcoind/elementsd, but lwk uses the electrum client on which lwk depends.

AddWaitForConfirmationTx(swapId, txId string, vout, startingHeight uint32, scriptpubkey []byte)

Wait for a specific tx to be confirmed with a specific block height.
This function uses the electrum client blockchain.scriptthash.get_history.

AddWaitForCsvTx(swapId, txId string, vout uint32, startingHeight uint32, scriptpubkey []byte)

Wait for a specific tx to reach the csv limit at a specific block height.
This function uses the electrum client blockchain.scriptthash.get_history.

GetBlockHeight() (uint32, error)

Function to retrieve block height.
Use blockchain.headers.subscribe of electrum client.

StartWatchingTxs() error

Function to start tx watcher.
Periodically calls blockchain.scripthash.get_history of electrum client and executes callback when the condition is met.

remove blockwatcher.go and associated block height functions The blockwatcher.go file and its associated functions for tracking block height changes have been removed. block height tracking is no longer necessary and has been replaced by a different mechanism.

`CreateFundedTransaction` and `FinalizeFundedTransaction` have merged interfaces, CreateAndBroadcastTransaction. This is because there was originally no reason to separate them, and because lwk uses the psbt format, transacrion conversion needs to be performed. The liquid wallet interface should not have a unique liquid wallet-dependent definition. However, there were some that depended on gelements, so they were separated out.

lwkclient is a library for interacting directly with lwk server via json rpc. LWKRpcWallet acts as an onchain wallet for peerswap It uses lwk and electrs. - Implement API structure with request handling, including retry logic and response body draining. - Provide configuration options for HTTP client with retry logic - Utilize JSON-RPC 2.0 for request and response handling. - Ensure proper error handling and logging. - Create lwkclient with methods for address generation, sending transactions, signing, broadcasting, balance querying, and wallet details retrieval. - Implement LWKRpcWallet with necessary wallet operations - Ensure wallet setup and transaction creation/broadcasting - Add utility functions for balance retrieval and fee estimation.

tx watcher is a function that monitors onchain status and notifies opening tx and closing tx. Introduce ElectrumRPC interface and electrumTxWatcher for Electrum-based transaction watching. Also, add generated mock for electrumRPC interface. Mock generation is performed by go.uber.org/mock/mockgen.

Input can be in toml or ini format, but each is managed as the same config. To make it loosely coupled, used the builder pattern to set item. I also add validation of the config. The config file cannot be modified from the outside.

RCasatta · 2024-05-03T09:36:57Z

packages.nix

+    # lwk: init at 0.3.0 #292522
+    # https://github.com/NixOS/nixpkgs/pull/292522/commits/2b3750792b2e4b52f472b6e6d88a6b02b6536c43
+    rev2 = "2b3750792b2e4b52f472b6e6d88a6b02b6536c43";
+    nixpkgs2 = fetchNixpkgs rev2;
+    pkgs2 = import nixpkgs2 {};
+    # blockstream-electrs: init at 0.4.1 #299761
+    # https://github.com/NixOS/nixpkgs/pull/299761/commits/680d27ad847801af781e0a99e4b87ed73965c69a
+    rev3 = "680d27ad847801af781e0a99e4b87ed73965c69a";
+    nixpkgs3 = fetchNixpkgs rev3;
+    pkgs3 = import nixpkgs3 {};
+    blockstream-electrs = pkgs3.blockstream-electrs.overrideAttrs (oldAttrs: {
+        cargoBuildFlags = [ "--features liquid" "--bin electrs" ];
+    });


There are also nix flakes for lwk and blockstream-electrs, I am curious to know if it was unknown or if it's preferred to avoid flakes

Thank you for confirming this.
I know that flake exists and I'm not trying to avoid installing it.

I don't know enough about nix but would it be better to add binLiquid to the package and use it for peerswap devShell?
I created draft PR of this.

I also seem to get build errors.
I think it should be fixed.

nix run .#blockstream-electrs-liquid -- --network liquid error: builder for '/nix/store/nkkv9v3r310p5gp09zv3hmn29y63mia3-electrs-deps-0.4.1.drv' failed with exit code 101; last 25 log lines: > Checking futures-channel v0.3.30 > Checking which v4.4.2 > Compiling bitcoind v0.34.1 > Checking rand v0.4.6 > Checking rustc-demangle v0.1.23 > Checking iana-time-zone v0.1.60 > Checking unicode-width v0.1.11 > Checking tower-service v0.3.2 > Checking winapi v0.2.8 > Checking option-ext v0.2.0 > Compiling bitcoin_hashes v0.10.0 > Checking base64-compat v1.0.0 > Checking dirs-sys v0.4.1 > Checking hyper v0.14.28 > Checking bitcoincore-rpc-json v0.18.0 > Compiling elementsd v0.9.1 > error[E0425]: cannot find function `download_filename` in this scope > --> /nix/store/n1a9vx4rppg99v909c7hw2jc5d1yj7f2-vendor-cargo-deps/c19b7c6f923b580ac259164a89f2577984ad5ab09ee9d583b888f934adbbe8d0/elementsd-0.9.1/build.rs:59:33 > | > 59 | let download_filename = download_filename(); > | ^^^^^^^^^^^^^^^^^ not found in this scope > > For more information about this error, try `rustc --explain E0425`. > error: could not compile `elementsd` (build script) due to previous error > warning: build failed, waiting for other jobs to finish... For full logs, run 'nix-store -l /nix/store/nkkv9v3r310p5gp09zv3hmn29y63mia3-electrs-deps-0.4.1.drv'. error: 1 dependencies of derivation '/nix/store/qpdjg9rmj3b9w33l50gmg4jdl8671738-electrs-0.4.1.drv' failed to build

Which commit are you using?

current new-index branch seems fine to me

$ git log | head -n 1 commit efc1fec8b0f96b5663d7257a0c2cffd8ef143219 $ nix run .#blockstream-electrs-liquid -- --network liquid Config { log: StdErrLog { verbosity: Error, quiet: false, show_level: true, timestamp: Off, modules: [], writer: "stderr", color_choice: Auto, show_module_names: false }, network_type: Liquid, db_path: "./db/liquid", daemon_dir: "/home/casatta/.bitcoin/liquidv1", blocks_dir: "/home/casatta/.bitcoin/liquidv1/blocks", daemon_rpc_addr: 127.0.0.1:7041, cookie: None, electrum_rpc_addr: 127.0.0.1:51000, http_addr: 127.0.0.1:3000, http_socket_file: None, monitoring_addr: 127.0.0.1:34224, jsonrpc_import: false, light_mode: false, address_search: false, index_unspendables: false, cors: None, precache_scripts: None, utxos_limit: 500, electrum_txs_limit: 500, electrum_banner: "Welcome to electrs-esplora 0.4.1", electrum_rpc_logging: None, parent_network: Bitcoin, asset_db_path: None }

I'm using the same commit.
There seems to be an error in my environment.

$ git log | head -n 1 commit efc1fec8b0f96b5663d7257a0c2cffd8ef143219 $ nix run .#blockstream-electrs-liquid -- --network liquid error: builder for '/nix/store/nkkv9v3r310p5gp09zv3hmn29y63mia3-electrs-deps-0.4.1.drv' failed with exit code 101; last 25 log lines: > Checking rand v0.4.6 > Checking tower-service v0.3.2 > Checking option-ext v0.2.0 > Checking winapi v0.2.8 > Checking rustc-demangle v0.1.23 > Checking unicode-width v0.1.11 > Compiling bitcoin_hashes v0.10.0 > Checking iana-time-zone v0.1.60 > Checking bitcoincore-rpc-json v0.18.0 > Checking base64-compat v1.0.0 > Checking chrono v0.4.34 > Checking textwrap v0.11.0 > Checking rand v0.3.23 > Checking hyper v0.14.28 > Checking dirs-sys v0.4.1 > Compiling elementsd v0.9.1 > error[E0425]: cannot find function `download_filename` in this scope > --> /nix/store/n1a9vx4rppg99v909c7hw2jc5d1yj7f2-vendor-cargo-deps/c19b7c6f923b580ac259164a89f2577984ad5ab09ee9d583b888f934adbbe8d0/elementsd-0.9.1/build.rs:59:33 > | > 59 | let download_filename = download_filename(); > | ^^^^^^^^^^^^^^^^^ not found in this scope > > For more information about this error, try `rustc --explain E0425`. > error: could not compile `elementsd` (build script) due to previous error > warning: build failed, waiting for other jobs to finish... For full logs, run 'nix log /nix/store/nkkv9v3r310p5gp09zv3hmn29y63mia3-electrs-deps-0.4.1.drv'. error: 1 dependencies of derivation '/nix/store/qpdjg9rmj3b9w33l50gmg4jdl8671738-electrs-0.4.1.drv' failed to build

can you try a nix flake update before nix run I am thinking to update the flake.lock anyway...

Hmmm, doesn't seem to solve the problem.

$ nix flake update warning: updating lock file '/workspaces/electrs/flake.lock': • Updated input 'crane': 'github:ipetkov/crane/a329cd00398379c62e76fc3b8d4ec2934260d636?narHash=sha256-iZDHWTqQj6z6ccqTSEOPOxQ8KMFAemInUObN2R9vHSs%3D' (2024-03-28) → 'github:ipetkov/crane/442a7a6152f49b907e73206dc8e1f46a61e8e873?narHash=sha256-uXNW6bapWFfkYIkK1EagydSrFMqycOYEDSq75GmUpjk%3D' (2024-05-04) • Updated input 'nixpkgs': 'github:NixOS/nixpkgs/2726f127c15a4cc9810843b96cad73c7eb39e443?narHash=sha256-UKcYiHWHQynzj6CN/vTcix4yd1eCu1uFdsuarupdCQQ%3D' (2024-03-27) → 'github:NixOS/nixpkgs/b211b392b8486ee79df6cdfb1157ad2133427a29?narHash=sha256-CLU5Tsg24Ke4%2B7sH8azHWXKd0CFd4mhLWfhYgUiDBpQ%3D' (2024-05-07) • Updated input 'rust-overlay': 'github:oxalica/rust-overlay/aa858717377db2ed8ffd2d44147d907baee656e5?narHash=sha256-oD4OJ3TRmVrbAuKZWxElRCyCagNCDuhfw2exBmNOy48%3D' (2024-03-28) → 'github:oxalica/rust-overlay/a8bfc2569a1965c0da8711d289d973f0011b441a?narHash=sha256-oujsCgNiQnZoQntNkkNkA7BhCmUvf9FLWj%2B2oGT2Jvc%3D' (2024-05-08) warning: Git tree '/workspaces/electrs' is dirty $ nix run .#blockstream-electrs-liquid -- --network liquid warning: Git tree '/workspaces/electrs' is dirty error: builder for '/nix/store/rcd2hcxdnb6v23c7mjjm33wqjbasdrvr-electrs-deps-0.4.1.drv' failed with exit code 101; last 25 log lines: > Compiling bitcoin_hashes v0.12.0 > Checking object v0.32.2 > Checking futures-channel v0.3.30 > Checking which v4.4.2 > Compiling bitcoind v0.34.1 > Checking rand v0.4.6 > Checking iana-time-zone v0.1.60 > Checking tower-service v0.3.2 > Checking rustc-demangle v0.1.23 > Checking unicode-width v0.1.11 > Compiling bitcoin_hashes v0.10.0 > Checking bitcoincore-rpc-json v0.18.0 > Checking option-ext v0.2.0 > Checking winapi v0.2.8 > Compiling elementsd v0.9.1 > error[E0425]: cannot find function `download_filename` in this scope > --> /nix/store/cjjfa06qzk9wahmbqjh7kn86bsmaq3dv-vendor-cargo-deps/c19b7c6f923b580ac259164a89f2577984ad5ab09ee9d583b888f934adbbe8d0/elementsd-0.9.1/build.rs:59:33 > | > 59 | let download_filename = download_filename(); > | ^^^^^^^^^^^^^^^^^ not found in this scope > > For more information about this error, try `rustc --explain E0425`. > Checking dirs-sys v0.4.1 > error: could not compile `elementsd` (build script) due to previous error > warning: build failed, waiting for other jobs to finish... For full logs, run 'nix log /nix/store/rcd2hcxdnb6v23c7mjjm33wqjbasdrvr-electrs-deps-0.4.1.drv'. error: 1 dependencies of derivation '/nix/store/z7wa0ixizb5xq32dfs8s0fv23yds4lcl-electrs-0.4.1.drv' failed to build

The integration test for LWK is added to ensure that the swap functionality works as expected with the LWK and electrs support. The setup functions are implemented to create the necessary test environment, including lwk, Bitcoin and Liquid nodes, as well as two lightning nodes with the PeerSwap. This setup is crucial for testing the swap-in process in an environment that closely mimics production. also, added Electrs and LWK structs for testing framework. - Implement `Electrs` struct to manage electrs daemon processes - Implement `LWK` struct to manage LWK daemon processes - Provide constructors for both structs to initialize with dynamic ports and configurations - Include methods to run the processes and connect

grubles · 2024-05-08T19:10:59Z

CLN as swap-out sender seems to be unable to get the starting block height from LWK?

Using CLN 24.02.2 and LWK 0.3.0

2eb4834f573c060d9200ce77544a29b48a0aa5923 got msgtype: a45d for swap: efa2c9c38ea24acff600af12d61677f50679b0e2d137fcd037c760411eaa4cfc
2024-05-08T19:09:05.555Z DEBUG   plugin-peerswap: [FSM] event:id: efa2c9c38ea24acff600af12d61677f50679b0e2d137fcd037c760411eaa4cfc, Event_OnTxOpenedMessage on State_SwapOutSender_AwaitTxBroadcastedMessage
2024-05-08T19:09:05.584Z INFO    plugin-peerswap: [FSM] Action failure could not get starting block height of the swap.
2024-05-08T19:09:05.585Z DEBUG   plugin-peerswap: [FSM] event:id: efa2c9c38ea24acff600af12d61677f50679b0e2d137fcd037c760411eaa4cfc, Event_ActionFailed on State_SwapOutSender_AwaitTxConfirmation
2024-05-08T19:09:05.591Z DEBUG   plugin-peerswap: [FSM] event:id: efa2c9c38ea24acff600af12d61677f50679b0e2d137fcd037c760411eaa4cfc, Event_ActionSucceeded on State_SwapOutSender_SendPrivkey
2024-05-08T19:09:05.592Z DEBUG   035ca2fe4793a5e789ce846062eb4834f573c060d9200ce77544a29b48a0aa5923-connectd: peer_out INVALID 42081
2024-05-08T19:09:05.599Z DEBUG   plugin-peerswap: [FSM] event:id: efa2c9c38ea24acff600af12d61677f50679b0e2d137fcd037c760411eaa4cfc, Event_ActionSucceeded on State_SwapOutSender_SendCoopClose
2024-05-08T19:09:05.600Z INFO    plugin-peerswap: [Swap:efa2c9c38ea24acff600af12d61677f50679b0e2d137fcd037c760411eaa4cfc] Swap claimed cooperatively

grubles · 2024-05-11T03:22:38Z

Yeah sure. It seemed to work before on the older commit.

[LWK]
signername="testsigner1"
walletname="testwallet1"
lwkendpoint="http://localhost:32111"
network="liquid-testnet"
liquidswaps=true

YusukeShimizu · 2024-05-13T02:12:08Z

Defalut electrs backend needs to perform a tls connection.
I confirm that peerswap is initialised and peerswap-listswaps can be done by the commit.
1bfe02c

Can you please confirm this?

grubles · 2024-05-13T16:49:49Z

Okay the latest commits fixed it.

The doc introduce configuration instructions for a new wallet kit (LWK) to support L-BTC swaps, providing users with additional options and flexibility for their swap setups.

restructure nixpkgs imports and package references. The changes introduce two new packages (`lwk` and `blockstream-electrs`).

wait for initial block header subscription to handle potential stalls. remove goroutines for Tx watchers. These do not need to be goroutine on the caller's side.

Add TLS support for Electrum. In default, the scheme is a tls connection, which allows connection to electrs. context timeout for wallet operations to enhance reliability.

The integration test for LWK and liquid is added to ensure that the swap functionality works as expected with the LWK and electrs support.

Validate lwk version before setting up the wallet. lwk is in a state where breaking changes occur frequently, making it difficult to guarantee operation except with a specific version.

nepet

Nice work!
ack afd5c76

nepet · 2024-05-28T09:20:11Z

lwk/lwkwallet.go

+	if err != nil {
+		satPerByte = minimumSatPerByte
+	}


A log line in case of an error could be helpful for debugging purposes in the future.

Thank you for confirming.
A fix has been made and log output has been added.

https://github.com/ElementsProject/peerswap/pull/288/files#diff-023bf190da1cb5d2f1e97d29c0d4c43624fabb6897db4573293921a3c3dab2cbR38

nepet · 2024-05-28T09:24:39Z

lwk/lwkwallet.go

 const (
-	kiloByte          = 1000
-	minimumSatPerByte = 0.1
+	minimumSatPerByte = 200


What is the rational behind setting the min sat per byte to 200?

This was my mistake and has been corrected to 0.1
https://github.com/ElementsProject/peerswap/pull/288/files#diff-023bf190da1cb5d2f1e97d29c0d4c43624fabb6897db4573293921a3c3dab2cbR28

To make lwk-related settings easier to understand, the following changes have been made. * Simplification of default settings in documentation * Clarified logging in case of incorrect configuration

add LWKConfig details to PeerSwapConfig String to include LWK configuration in the output.

Add race detector flag to go test command for better concurrency checks. Fixes have been implemented for the race conditions detected in the above tests. Fixed a bug in the slice remove process.

To optimise the log output of the transaction watcher, only output to the required debug log. Also, swap.ErrDoesNotExist is now handled in the callback.

YusukeShimizu force-pushed the lwk-swap branch 8 times, most recently from 8603558 to 37f5bcd Compare March 29, 2024 07:51

YusukeShimizu force-pushed the lwk-swap branch 3 times, most recently from 02832df to e7513c6 Compare May 1, 2024 00:47

YusukeShimizu added 2 commits May 1, 2024 12:35

YusukeShimizu force-pushed the lwk-swap branch from e7513c6 to e6194f3 Compare May 1, 2024 03:36

YusukeShimizu added 2 commits May 1, 2024 12:56

multi: lwk configuration support for Liquid swaps

ab80a53

Input can be in toml or ini format, but each is managed as the same config. To make it loosely coupled, used the builder pattern to set item. I also add validation of the config. The config file cannot be modified from the outside.

YusukeShimizu force-pushed the lwk-swap branch 2 times, most recently from 48f67fd to e7769ed Compare May 2, 2024 06:08

RCasatta reviewed May 3, 2024

View reviewed changes

YusukeShimizu force-pushed the lwk-swap branch from 96983c5 to 8157268 Compare May 5, 2024 22:55

YusukeShimizu force-pushed the lwk-swap branch from 8157268 to 538b83c Compare May 5, 2024 22:59

YusukeShimizu changed the title ~~wip: make lwk available~~ make lwk available May 6, 2024

YusukeShimizu marked this pull request as ready for review May 6, 2024 01:05

YusukeShimizu force-pushed the lwk-swap branch 4 times, most recently from 44c7d05 to a448d46 Compare May 9, 2024 07:39

YusukeShimizu force-pushed the lwk-swap branch 4 times, most recently from 6277589 to 1bfe02c Compare May 13, 2024 00:39

YusukeShimizu added 5 commits May 14, 2024 08:16

doc: add LWK setup guide

8ad9a7a

The doc introduce configuration instructions for a new wallet kit (LWK) to support L-BTC swaps, providing users with additional options and flexibility for their swap setups.

nix: add lwk and blockstream-electrs packages

cdd89ea

restructure nixpkgs imports and package references. The changes introduce two new packages (`lwk` and `blockstream-electrs`).

wip: claim_coop case

3fe81f6

txwather: wait for initial block header sub

383a143

wait for initial block header subscription to handle potential stalls. remove goroutines for Tx watchers. These do not need to be goroutine on the caller's side.

lwk: add TLS support for Electrum

381daa1

Add TLS support for Electrum. In default, the scheme is a tls connection, which allows connection to electrs. context timeout for wallet operations to enhance reliability.

YusukeShimizu force-pushed the lwk-swap branch from 1bfe02c to 381daa1 Compare May 13, 2024 23:16

YusukeShimizu mentioned this pull request May 22, 2024

[feature request]:use electrum server for fee rate estimation Blockstream/lwk#33

Open

YusukeShimizu added 2 commits May 24, 2024 08:46

test: add integration test for LWK and liquid

1041bed

The integration test for LWK and liquid is added to ensure that the swap functionality works as expected with the LWK and electrs support.

lwk: check if the version is supported

58c516c

Validate lwk version before setting up the wallet. lwk is in a state where breaking changes occur frequently, making it difficult to guarantee operation except with a specific version.

YusukeShimizu force-pushed the lwk-swap branch from 2225a41 to afd5c76 Compare May 27, 2024 23:42

nepet approved these changes May 28, 2024

View reviewed changes

config: make lwk-related settings clear

53e56fd

To make lwk-related settings easier to understand, the following changes have been made. * Simplification of default settings in documentation * Clarified logging in case of incorrect configuration

YusukeShimizu force-pushed the lwk-swap branch from afd5c76 to 53e56fd Compare May 29, 2024 06:04

YusukeShimizu added 2 commits May 30, 2024 09:10

config: include LWK configuration in the output

83603a2

add LWKConfig details to PeerSwapConfig String to include LWK configuration in the output.

lwk: ensure thread safety

d1f6a89

Add race detector flag to go test command for better concurrency checks. Fixes have been implemented for the race conditions detected in the above tests. Fixed a bug in the slice remove process.

YusukeShimizu force-pushed the lwk-swap branch 6 times, most recently from 2545a59 to b363138 Compare May 31, 2024 08:33

electrum: proper log output of tx watcher

f2ee818

To optimise the log output of the transaction watcher, only output to the required debug log. Also, swap.ErrDoesNotExist is now handled in the callback.

YusukeShimizu force-pushed the lwk-swap branch from b363138 to f2ee818 Compare May 31, 2024 09:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make lwk available #288

make lwk available #288

YusukeShimizu commented Mar 11, 2024 •

edited

RCasatta May 3, 2024

YusukeShimizu May 8, 2024

RCasatta May 8, 2024

YusukeShimizu May 8, 2024

RCasatta May 8, 2024

YusukeShimizu May 9, 2024

grubles commented May 8, 2024 •

edited

grubles commented May 11, 2024 •

edited

YusukeShimizu commented May 13, 2024

grubles commented May 13, 2024

nepet left a comment

nepet May 28, 2024

YusukeShimizu May 29, 2024 •

edited

nepet May 28, 2024

YusukeShimizu May 29, 2024

make lwk available #288

Are you sure you want to change the base?

make lwk available #288

Conversation

YusukeShimizu commented Mar 11, 2024 • edited

lbtc swap with lwk

Description

setup

Specification

Configuration

wallet

GetAddress() (string, error)

SendToAddress(string, uint64) (string, error)

CreateAndBroadcastTransaction(swapParams *swap.OpeningParams, asset []byte) (txid, rawTx string, fee uint64, err error)

SendRawTx(rawTx string) (txid string, err error)

GetFee(txSize int64) (uint64, error)

tx watcher

AddWaitForConfirmationTx(swapId, txId string, vout, startingHeight uint32, scriptpubkey []byte)

AddWaitForCsvTx(swapId, txId string, vout uint32, startingHeight uint32, scriptpubkey []byte)

GetBlockHeight() (uint32, error)

StartWatchingTxs() error

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grubles commented May 8, 2024 • edited

grubles commented May 11, 2024 • edited

YusukeShimizu commented May 13, 2024

grubles commented May 13, 2024

nepet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YusukeShimizu May 29, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YusukeShimizu commented Mar 11, 2024 •

edited

grubles commented May 8, 2024 •

edited

grubles commented May 11, 2024 •

edited

YusukeShimizu May 29, 2024 •

edited