Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #7323

Closed
wants to merge 2 commits into from
Closed

Fix CI #7323

wants to merge 2 commits into from

Conversation

endothermicdev
Copy link
Collaborator

Update mocks and skip a flaky test.

This test commonly fails under CI and is holding up merging PRs:

ERROR tests/test_renepay.py::test_limits - ValueError:
Node errors:
 - lightningd-1: had memleak messages

FAILED tests/test_closing.py::test_anchorspend_using_to_remote[True] -
TimeoutError: Unable to find "[re.compile('hsmd: Unilateral close
output, deriving secrets')]" in logs.
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uuh! skipping tests looks like hiding a bugs, but I am not following close the CI stuff.

What is the reason why we are disabling this two tests?

@Lagrang3
Copy link
Collaborator

PR #7307 should fix the memory leak in the renepay test.

@endothermicdev
Copy link
Collaborator Author

Cherry-picked the first commit and the renepay test has been resolved. Closing this as CI is mostly in order now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants