offer: fix typo to the getchaininfo rpc

[vincenzopalazzo]

This is violate what the docs of getchainfo are telling us that the last_block_height is a u64.

2024-05-17T09:53:23.464Z **BROKEN** plugin-offers: Got error reply to getchaininfo: '{\"error\":{\"code\":-1,\"data\":null,\"message\":\"invalid type: string \\\"0\\\", expected u64\"},\"id\":\"init/offers:getchaininfo#1\",\"jsonrpc\":\"2.0\"}\n\n'
2024-05-17T09:53:23.496Z INFO    plugin-offers: Killing plugin: exited before replying to init
2024-05-17T09:53:23.496Z **BROKEN** plugin-offers: Plugin marked as important, shutting down lightningd!
2024-05-17T09:53:23.496Z DEBUG   lightningd: io_break: lightningd_exit
2024-05-17T09:53:23.496Z **BROKEN** plugin-topology: Reading JSON input: Connection reset by peer
2024-05-17T09:53:23.504Z INFO    plugin-topology: Killing plugin: exited before replying to init
2024-05-17T09:53:23.504Z **BROKEN** plugin-topology: Plugin marked as important, shutting down lightningd!
2024-05-17T09:53:23.504Z DEBUG   lightningd: io_break: lightningd_exit
2024-05-17T09:53:23.504Z DEBUG   plugin-bookkeeper: Setting up database at sqlite3://accounts.sqlite3
2024-05-17T09:53:23.504Z DEBUG   connectd: REPLY WIRE_CONNECTD_START_SHUTDOWN_REPLY with 0 fds
2024-05-17T09:53:23.504Z DEBUG   lightningd: io_break: connectd_start_shutdown_reply

Fixing the following crash

Got error reply to getchaininfo: '{"error":{"code":-1,"data":null,"message":"invalid type: string \"0\", expected u64"},"id":"init/offers:getchaininfo#1","jsonrpc":"2.0"}

'lightningd: lightningd already running? Error locking PID file: Resource temporarily unavailable

Changelog-None: offer: fix type to the getchaininfo rpc

[vincenzopalazzo]

wondering if this was already fixed in some commit

ld tools/check-bolt
tests/test_cln_rs.py:406:17: F405 'reserve' may be undefined, or defined from star imports: fixtures
tests/test_cln_rs.py:424:17: F405 'reserve' may be undefined, or defined from star imports: fixtures
tests/test_cln_rs.py:439:17: F405 'reserve' may be undefined, or defined from star imports: fixtures

I should look more at the git history

[endothermicdev]

The port reserve issue was just introduced by two PRs merged in quick succession. I think this commit should resolve it if you want to cherry-pick it.

[vincenzopalazzo]

Ah ok I remember that I see something that was fixing this problem :)

Well I ack the PR and then I will rebase on top of yours, thanks

[vincenzopalazzo]

Trivial rebased on master, now this should include the @endothermicdev patch, thanks!

[vincenzopalazzo]

Please note that 476cdfb

It is my fault that I made this a requirement parameter, this should be optional to allow use cases like the offer plugin.

[endothermicdev]

I think the commits are out of order here - the argument should be made optional before it stops being passed. LGTM otherwise.

[vincenzopalazzo]

Rebased and addressing the review, thanks @endothermicdev