fix: peer_control getinfo to show correct port on discovered IPs #5585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-schmoock
changed the title
Changelog-Fixed: peer_control: getinfo shows the correct port on discovered IPs
m-schmoock
force-pushed
the
fix/getinfo_ip_discovery_port
branch
from
2d46018
to
bcb6d32
Compare
m-schmoock
changed the title
This is cleaner because, the `remote_addr` and `discovered_ip` are related but two different things. Within connectd and lightningd we use the peers `remote_addr` feature to validate (and guess a port) to be used for IP discovery. Also when a peer reports us a `remote_addr`, this is given to the plugin API via the `peer_connected` hook. The network port here is not modified for godd reason! This can be used i.e. to detect if we are behind a NAT. But once lightningd figures enough peers report the same `remote_addr`, it sets the port to the selected network and tells gossipd to use that for `node_announcement` updates. Hence, within gossipd, there is no (should not be) `remote_addr`. Changelog-None
m-schmoock
force-pushed
the
fix/getinfo_ip_discovery_port
branch
from
b842571
to
8fb6ed8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, getinfo shows incorrect ports on
getinfoauto discovered IP addresses.It also just showed (not announced) unconfirmed addresses.
Addresses #5553
Changelog-Fixed: peer_control: getinfo shows the correct port on discovered IPs