Allow IpcMain to send IPC messages to BrowserViews #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
IpcMaincan only send IPC messages toBrowserWindows, because theSendmethod'sbrowserWindowparameter is strongly typed toBrowserWindow. This PR overloads theSendmethod to accept aBrowserViewas well, emitting thesendToIpcRendererBrowserViewsocket message with the same implementation. The host receives this message inipc.ts, locates theBrowserViewwith the given ID from the globalbrowserViewsarray created inbrowserView.ts, and sends the IPC message to itswebContents.