Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/527 #528

Merged
merged 7 commits into from
Jan 21, 2021
Merged

Issue/527 #528

merged 7 commits into from
Jan 21, 2021

Conversation

danatcofo
Copy link
Contributor

@danatcofo danatcofo commented Jan 19, 2021

This PR contains a couple different things separated out int different commits.

Example for the Dock Menu

Electron.Dock.SetMenu(new [] {
   new MenuItem {
      Label = "Dock Menu Item",
      Click = () => {
         // do something
      }
   },
});

Example for consuming the activate event (MacOs only)

Electron.App.On("activate", obj => {
   var hasWindows = (bool)obj;
   // do something
});

fix #500
fix #527

Dan added 7 commits January 18, 2021 10:30
Used for class composition with IServiceProvider
`Electron.App.On("eventName", () => {});` or `Electron.App.On("eventName", obj => {});`

fix ElectronNET#527
The jump from Election 9x to 11x changed the default setting.  This exposes it so that user can re-enable it if needed.
@GregorBiswanger
Copy link
Member

Thank you for your contribution! Write me your postal address on Gitter and you will get Electron.NET sticker :)

@GregorBiswanger GregorBiswanger merged commit cc0b15c into ElectronNET:master Jan 21, 2021
@IIiKoBiT
Copy link

@GregorBiswanger
@danatcofo

After setting browserWindowOptions.WebPreferences.EnableRemoteModule = true;
The application will stop starting.

image

There is a process, but the window is not created or shown, I'm not exactly sure.

After the update, the code related to selecting a file from the system stopped working for me, as I understood I need to specify browserWindowOptions.WebPreferences.EnableRemoteModule = true; what would it work. But after that, the window completely stops working.

image

@danatcofo
Copy link
Contributor Author

What version of electron are you using?

@danatcofo danatcofo deleted the issue/527 branch December 7, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants