Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .NET 5 #509

Merged
merged 3 commits into from
Jan 10, 2021
Merged

Upgrade to .NET 5 #509

merged 3 commits into from
Jan 10, 2021

Conversation

scottkuhl
Copy link
Contributor

@scottkuhl scottkuhl commented Nov 21, 2020

Upgraded projects from .NET 3.1 to .NET 5.0.

Upgraded WebApp project from TypeScript 3.8 to TypeScript 5.0.

Upgraded NuGet packages to the latest versions:

  • Microsoft.SourceLink.GitHub 1.0.0-beta2-19367-01 > 1.0.0
  • System.Drawing.Common 4.7.0 > 5.0.0
  • Microsoft.VisualStudio.Web.CodeGeneration.Design 3.0.0 > 5.0.0

This addresses issue #491

- Microsoft.SourceLink.GitHub 1.0.0-beta2-19367-01 > 1.0.0
- System.Drawing.Common 4.7.0 > 5.0.0
- Microsoft.VisualStudio.Web.CodeGeneration.Design 3.0.0 > 5.0.0
@scottkuhl
Copy link
Contributor Author

I don't see any testing guidelines on the repo. I was able to run the web app to test the changes and fire off demo code.

image

@GregorBiswanger GregorBiswanger added this to the 10.5.1 milestone Nov 21, 2020
@GregorBiswanger GregorBiswanger self-assigned this Nov 21, 2020
@Delpire
Copy link

Delpire commented Dec 8, 2020

Will this change mean that our existing .NET Core 3.1 projects will no longer be able to update versions of Electron .NET?

@scottkuhl
Copy link
Contributor Author

If you were to use the .NET 5 version I think you would need to update your project to .Net 5 as well. From Core 3.1 that should be possible but of course not everyone will want to do that.

@Delpire
Copy link

Delpire commented Dec 9, 2020

Yeah I am not sure we'll want to do that. .NET Core 3.1 and then .NET 6 are the long term support versions from Microsoft. I would still like to be able to get fixes and new features from Electron .NET without having to upgrade to .NET 5.

Unless you guys are planning on adding some .NET 5 specific features, is there really any reason to drop .NET Core 3.1 support. Could you not still build and ship both in a NuGet package?

@scottkuhl
Copy link
Contributor Author

That's probably a better question for Gregor to answer. He is planning out the next milestone release now.

@ErikApption
Copy link

ErikApption commented Dec 9, 2020

Fantastic - I could really use this version - when is it going to hit nuget (even in preview form)?

@GregorBiswanger
Copy link
Member

I think the new version will only be compatible with .NET 5. However, the 9.31.x version can still be used. I think otherwise we will get mixed up on two tracks.

@arne309
Copy link

arne309 commented Jan 4, 2021

Is there any ETA on when this will be available on nuget?

@GregorBiswanger
Copy link
Member

@arne309 I still have three weeks vacation. Definitely will publish it in the next few weeks.

@GregorBiswanger GregorBiswanger merged commit 335489d into ElectronNET:master Jan 10, 2021
@ErikApption
Copy link

It looks like this feature is merged - is there any bug holding from doing a beta release in nuget?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants