Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

description added to package.json #433

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

BurtsevC
Copy link
Contributor

@BurtsevC BurtsevC commented Jun 13, 2020

Description bug fix #432

@GregorBiswanger GregorBiswanger added this to the 9.31.2 milestone Jun 13, 2020
@GregorBiswanger GregorBiswanger self-assigned this Jun 13, 2020
@GregorBiswanger
Copy link
Member

Thank you for your contribution! Write me your postal address on Gitter and you will get Electron.NET sticker :)

@GregorBiswanger
Copy link
Member

Did you also test whether it takes over the description at runtime?

@MarkBQE
Copy link

MarkBQE commented Jun 13, 2020

I had a similar issue, in release version it is fine. However after the last update it got fixed both in dev as well as release

@BurtsevC
Copy link
Contributor Author

Did you also test whether it takes over the description at runtime?

I have checked that the Setup file description changed as well as Comment of the lnk file after installation. But an .exe file of the program has the same File description as Product name. I also saw the same behavior in the "pure" Electron.

@GregorBiswanger GregorBiswanger modified the milestones: 9.31.2, 9.31.3 Jul 22, 2020
@GregorBiswanger GregorBiswanger merged commit 814e046 into ElectronNET:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Description bug in setup file
3 participants