Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept https proxy fixes #10 #11

Merged
merged 10 commits into from
Dec 13, 2022
Merged

Accept https proxy fixes #10 #11

merged 10 commits into from
Dec 13, 2022

Conversation

tebruno99
Copy link

Original PR: gorilla#740 by @philipatl

Fixes gorilla#739 #10

Summary of Changes

call proxy_RegisterDialerType for the https scheme to allow communication to https proxies
some scheme-specific setup is necessary in Dialer's DialContext in order to use the TLSClientConfig
add a UsesTLS method to the proxy_Dialer interface to ensure the https forwardDialer can inspect that https is supported, and to adjust if necessary

@tebruno99 tebruno99 self-assigned this Dec 13, 2022
@tebruno99 tebruno99 changed the title Accept https proxy Accept https proxy fixes #10 Dec 13, 2022
@tebruno99 tebruno99 merged commit 32aafbf into ElasticPerch:enhancement/10-feature-support-for-proxying-websocket-through-https-proxy Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tebruno99 tebruno99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tebruno99 @philipatl