Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CF] (Security) Upgrade "rollup-plugin-license" to resolve vulnerability in MomentJS #29

Merged
merged 1 commit into from Sep 6, 2022
Merged

[CF] (Security) Upgrade "rollup-plugin-license" to resolve vulnerability in MomentJS #29

merged 1 commit into from Sep 6, 2022

Conversation

craigfay
Copy link
Collaborator

@craigfay craigfay commented Sep 6, 2022 •
edited

Description

  • Prior to 2.29.4, moment had a bug which causes specific date inputs to use n^2 complexity.
  • The issue is rooted in the code that removes legacy comments (stuff inside parenthesis) from strings during rfc2822 parsing. moment("(".repeat(500000)) will take a few minutes to process.
  • Moonshine uses a version of rollup-plugin-license that depends on a vulnerable version of moment.

Changes

@craigfay craigfay merged commit b0400fc into main Sep 6, 2022
@craigfay craigfay deleted the cf-patch-moment-n-squared-bug branch September 6, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw00 tw00 tw00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@craigfay @tw00