Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 12 and all JS deps #144

Merged
merged 13 commits into from May 27, 2021
Merged

Angular 12 and all JS deps #144

merged 13 commits into from May 27, 2021

Conversation

PowerKiKi
Copy link
Member

Except:

  • @types/node, we run on node 14
  • rxjs, Angular does not support 7 yet

Except:

- @types/node, we run on node 14
- rxjs, Angular does not support 7 yet
@PowerKiKi
Copy link
Member Author

PowerKiKi commented May 24, 2021

Also see if kamilkisiela/apollo-angular@e987604 was released before we merge this PR

Instead of using the new auto-magic validators for min/max, we
keep using our manually set validators via code, while keep using
the browser native features for min/max validation
Because it is not compatible with the new `@use` from SASS:

reactway/scss-bundle#90

So instead we ship raw SCSS files to be consumed by the app.
That avoids ngc compilation for end-user but requires them to have an Ivy app
Instead use standard `??` operator in template (even though PhpStorm
thinks it is a mistake)
Except:

- @types/node, we run on node 14
- rxjs, Angular does not support 7 yet
- typescript, Angular does not support 4.3 yet
@PowerKiKi PowerKiKi merged commit 3dfbd33 into master May 27, 2021
@PowerKiKi PowerKiKi deleted the angular-12 branch August 17, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant