New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 12 and all JS deps #144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Except: - @types/node, we run on node 14 - rxjs, Angular does not support 7 yet
PowerKiKi
commented
May 24, 2021
projects/natural/src/lib/modules/dropdown-components/type-number/type-number.component.html
Outdated
Show resolved
Hide resolved
Also see if kamilkisiela/apollo-angular@e987604 was released before we merge this PR |
Instead of using the new auto-magic validators for min/max, we keep using our manually set validators via code, while keep using the browser native features for min/max validation
Because it is not compatible with the new `@use` from SASS: reactway/scss-bundle#90 So instead we ship raw SCSS files to be consumed by the app.
That avoids ngc compilation for end-user but requires them to have an Ivy app
Instead use standard `??` operator in template (even though PhpStorm thinks it is a mistake)
Except: - @types/node, we run on node 14 - rxjs, Angular does not support 7 yet - typescript, Angular does not support 4.3 yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Except: