Fix version syntax in the environment file #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSchilperoort
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
Looks good. I prefer going from small to big when specifying a range of versions (e.g. python>=3.8,<3.11, but I guess this is just a personal preference. :)
Prospector being broken has been quite frustrating for me too, and different things keep breaking when they release a new version.
Good point, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sonarcloud check failed due to
WARNING: prospector 1.8.1 does not provide the extra 'with_pyroma'which is a bug.