Conversation
Hi @linkfang, thanks for preparing the changes. Please have a look at the following two things:
Thanks! Before: After: |
Hi @ahus1 , good catch and good suggestion! Now it's solved! Hi @chrisguindon , Yeah, sure, it's removed. |
@linkfang - the other PR is now merged into main. Unfortunately this PR now has a merge conflict: please resolve them. Please consider squashing the commits in this ticket before I merge them into main; alternatively I can squash the commits via the GitHub web UI. |
@ahus1 I think it's preferable that you squash them when you merge the PR! That's what I usually do.. |
@chrisguindon - looking at this issue this is awaiting a review approval from you. Please leave a note here if you plan to do some work here or if you're done. Besides that I'm now ready to merge. |
Is it really necessary to put the registered trademark symbol on AsciiDoc in both the title and the description of the hero? Can't we just put it in one place? If I have a choice, it would be in the description. |
@mojavelinux I will share your question with our Trademark specialist. We are currently acting under their direction for this. |
We don't need it in both places. We usually add it in the first occurrence of the word but it's fine to only keep it in the description. @linkfang Can you make this last change please? |
…iiDoc to the list of trademarks in the README Signed-off-by: Alexander Schwartz <alexander.schwartz@gmx.net>
Thank you for everyone involved here. The change is now live. |
For Infra-4243
Got +1 from Sharon