New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security: set-output
cmd deprecated. Use $GITHUB_OUTPUT
env file
#9287
security: set-output
cmd deprecated. Use $GITHUB_OUTPUT
env file
#9287
Conversation
To avoid untrusted logged data to use `save-state` and `set-output` workflow commands without the intention of the workflow author we have introduced a new set of environment files to manage state and output. Starting 1st June 2023 workflows using `save-state` or `set-output` commands via stdout will fail with an error. https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Doing some tests to know how to fix awesomebot GitHub summary report Compare: |
Now it works again: https://github.com/EbookFoundation/free-programming-books/actions/runs/4243200736 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me. ✅
- No instances of
set-output
orsave-state
were missed in the workflow files. Verified with spotlight search of the repo. - Workflow checks are passing and output is properly formatted.
My only nit would be to squash these test commits into one.
::set-output --> GITHUB_OUTPUT env file
* ci(check-urls): use a matrix to speed-up execution The matrix strategy creates 10 max-parallel workers with a disabled fail-fast parameter Examples - Before: https://github.com/davorpa/free-programming-books/actions/runs/2999590952 - After: https://github.com/davorpa/free-programming-books/actions/runs/3007199364 Running the workflow when -langs or -subject files are involved could exhaust the runner execution max-time. Using this implementation... the elapsed time is of the longest execution time, normally no more than 30min on the worst of cases * fix: parallel strategy when matrix files.length == 0 * security: apply #9287 ::set-output --> GITHUB_OUTPUT env file
What does this PR do?
Improve repo
For resources
Description
Starting 1st June 2023 workflows using
save-state
orset-output
commands via stdout will fail with an error.More info:
Why is this valuable (or not)?
It patches the deprecation
Checklist:
Follow-up