Correctly provide file locations for errors and warnings when using preprocessors #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could use https://github.com/jridgewell/trace-mapping which is smaller |
|
Gonna hold off releasing this since it looks like Svelte is slowly moving towards a v4 release which will unbundle it's dependencies (one of which is |
EMH333
force-pushed
the
preprocess-warning-location
branch
from
033f976
to
2979d6e
Compare
EMH333
force-pushed
the
preprocess-warning-location
branch
2 times, most recently
from
358442f
to
1a161cf
Compare
Adds dependency on source-map but results in better warning locations. Still need to figure out way to deal with error messages
Fixes error location for svelte errors not in preprocessor code. If the error is because of a preprocessor then it is either using the original source and should be fine, or using the source from another preprocessor in which case there isn't enough data to extract a valid line location since the sourcemap won't have been returned yet
EMH333
force-pushed
the
preprocess-warning-location
branch
from
c5e9ca5
to
a5a381e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Mozilla's
source-maplibrary to parse the sourcemaps from preprocessors to correctly return the error/warning location in the original file.Fixes #83