Fix returning watchFiles

EMH333 · Sep 5, 2023 · 5be8376 · 5be8376
1 parent 48777f1
commit 5be8376
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/index.ts b/index.ts
@@ -281,11 +281,20 @@ export default function sveltePlugin(options?: esbuildSvelteOptions): Plugin {
                     }
 
                     // make sure to tell esbuild to watch any additional files used if supported
-                    result.watchFiles = Array.from(dependencyModifcationTimes.keys());
+                    // only provide if context API is supported or we are caching
+                    if (build.esbuild?.context !== undefined || shouldCache(build)) {
+                        result.watchFiles = Array.from(dependencyModifcationTimes.keys());
+                    }
 
                     return result;
                 } catch (e: any) {
-                    return { errors: [convertMessage(e)], watchFiles: previousWatchFiles };
+                    let result: OnLoadResult = {};
+                    result.errors = [convertMessage(e)];
+                    // only provide if context API is supported or we are caching
+                    if (build.esbuild?.context !== undefined || shouldCache(build)) {
+                        result.watchFiles = previousWatchFiles;
+                    }
+                    return result;
                 }
             });
 

diff --git a/package.json b/package.json
@@ -16,7 +16,7 @@
     "preversion": "npm run lint && npm run build && npm test && npm run test:compatibility",
     "pretest": "tsc -p tsconfig.json --noEmit",
     "test": "uvu test/ .*\\.mjs",
-    "test:compatibility": "test/versionTests/versionTests.sh",
+    "test:compatibility": "npm run build && test/versionTests/versionTests.sh",
     "build": "node build.js",
     "lint": "prettier --check --cache .",
     "fix": "prettier --write --cache ."