Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macenko stain augmentation #45

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

andreped
Copy link
Collaborator

@andreped andreped commented May 8, 2023

Related to issue #43.

Changes

  • I implemented StainTools-like Macenko augmentation for all three backends.
  • It also made a sense to implement an augmentation example script, and thus I moved both examples to their own dedicated apps/.
  • Due to this, I changed to run tests on macos-12 instead of macos-11
  • I also fixed a step in the tests CI which failed due to breaking change in artifact download

Ideas from improvement

API-wise I believe there is a lot of overlap between the normalization and augmentation techniques. It would make sense to have a Macenko ABC class, of which the MacenkoNormalizer and MacenkoAugmentor classes inherit from, and then for each we just override the necessary methods.

Screenshot 2023-05-08 at 17 00 43

@andreped
Copy link
Collaborator Author

andreped commented Apr 1, 2024

@carloalbertobarbano I observed that it was not possible to change sigma_1 and sigma_2 through the common MacenkoAugmentor API. I also observed that tests were failing due to some bugs in the CI workflows. I have addressed both now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant