Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit tenant UUID returned by tenant #3124

Merged
merged 10 commits into from
Jun 4, 2024

Conversation

gkrenn
Copy link
Contributor

@gkrenn gkrenn commented May 6, 2024

Description

Currently the tenant UUID is derived from the URL provided in the dynakube.
It is never guaranteed that the url contains a valid UUID and can even be an alias.

This PR updates the corresponding code to use the UUID returned by the tenant itself.

Jira Ticket

How can this be tested?

Run cloudNative e2e test and check if everything works as expected.
Run resilience test to verify that even with limited connectivity the CSI driver works as expected.

@gkrenn gkrenn added the core Changes to core functionality of the Operator label May 6, 2024
@gkrenn gkrenn requested a review from a team as a code owner May 6, 2024 16:17
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

Attention: Patch coverage is 68.57143% with 22 lines in your changes missing coverage. Please review.

Project coverage is 58.77%. Comparing base (b71ca39) to head (c55b68a).

Files Patch % Lines
...kg/controllers/dynakube/dtpullsecret/reconciler.go 71.87% 5 Missing and 4 partials ⚠️
pkg/api/v1beta2/dynakube/properties.go 0.00% 7 Missing ⚠️
...ntrollers/dynakube/oneagent/oneagent_reconciler.go 20.00% 3 Missing and 1 partial ⚠️
pkg/controllers/dynakube/activegate/reconciler.go 66.66% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3124      +/-   ##
==========================================
+ Coverage   58.75%   58.77%   +0.01%     
==========================================
  Files         326      326              
  Lines       18128    18172      +44     
==========================================
+ Hits        10651    10680      +29     
- Misses       6298     6308      +10     
- Partials     1179     1184       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/api/v1beta1/dynakube/properties.go Outdated Show resolved Hide resolved
pkg/controllers/dynakube/controller.go Outdated Show resolved Hide resolved
@gkrenn gkrenn marked this pull request as draft May 7, 2024 12:12
@gkrenn gkrenn force-pushed the feature/uuid-from-connection-info branch 2 times, most recently from 8d7fb92 to 2a42573 Compare May 7, 2024 13:17
@gkrenn gkrenn requested a review from 0sewa0 May 7, 2024 13:22
@gkrenn gkrenn marked this pull request as ready for review May 7, 2024 13:22
@gkrenn gkrenn marked this pull request as draft May 7, 2024 15:22
@gkrenn gkrenn force-pushed the feature/uuid-from-connection-info branch from 2a42573 to 2cad644 Compare May 21, 2024 20:04
@gkrenn
Copy link
Contributor Author

gkrenn commented May 21, 2024

Updated the pull secret reconciler and added conditions + cleanup logic

Pull Secret Reconciler is not called from within oneagent reconciler and active gate reconciler

@gkrenn gkrenn marked this pull request as ready for review May 21, 2024 20:25
@gkrenn gkrenn requested a review from 0sewa0 May 21, 2024 20:25
@gkrenn gkrenn force-pushed the feature/uuid-from-connection-info branch from 2cad644 to edaeba6 Compare May 27, 2024 11:35
@gkrenn gkrenn force-pushed the feature/uuid-from-connection-info branch from edaeba6 to 38b0b18 Compare May 28, 2024 15:39
@gkrenn gkrenn requested a review from 0sewa0 May 28, 2024 15:58
Copy link
Contributor

@0sewa0 0sewa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, but there are some inconsistencies in logging that we should fix

pkg/controllers/dynakube/dtpullsecret/reconciler.go Outdated Show resolved Hide resolved
pkg/controllers/dynakube/oneagent/oneagent_reconciler.go Outdated Show resolved Hide resolved
pkg/controllers/dynakube/oneagent/oneagent_reconciler.go Outdated Show resolved Hide resolved
@gkrenn gkrenn force-pushed the feature/uuid-from-connection-info branch from 38b0b18 to 7fdeaf8 Compare June 3, 2024 08:27
@gkrenn gkrenn requested review from 0sewa0 and waodim June 3, 2024 12:49
Copy link
Contributor

@waodim waodim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkrenn gkrenn merged commit 0a3f2d2 into main Jun 4, 2024
19 checks passed
@gkrenn gkrenn deleted the feature/uuid-from-connection-info branch June 4, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to core functionality of the Operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants