-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use explicit tenant UUID returned by tenant #3124
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3124 +/- ##
==========================================
+ Coverage 58.75% 58.77% +0.01%
==========================================
Files 326 326
Lines 18128 18172 +44
==========================================
+ Hits 10651 10680 +29
- Misses 6298 6308 +10
- Partials 1179 1184 +5 ☔ View full report in Codecov by Sentry. |
8d7fb92
to
2a42573
Compare
2a42573
to
2cad644
Compare
Updated the pull secret reconciler and added conditions + cleanup logic Pull Secret Reconciler is not called from within oneagent reconciler and active gate reconciler |
2cad644
to
edaeba6
Compare
edaeba6
to
38b0b18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected, but there are some inconsistencies in logging that we should fix
38b0b18
to
7fdeaf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Currently the tenant UUID is derived from the URL provided in the dynakube.
It is never guaranteed that the url contains a valid UUID and can even be an alias.
This PR updates the corresponding code to use the UUID returned by the tenant itself.
Jira Ticket
How can this be tested?
Run cloudNative e2e test and check if everything works as expected.
Run resilience test to verify that even with limited connectivity the CSI driver works as expected.