Introduce new version v1beta2 for DynaKube and add conversion logic

[waodim]

With this introduction and conversion logic of version v1beta2 for the DynaKube is done. Version v1alpha1 is removed for DynaKube and the new hubVersion is v1beta1. It is also the storageVersion

Summary of things that are added:

• a new field metaDataEnrichment was added to the .spec of the Dynakube. it has an enabled field (enabled by default) and a namespace selector.
• a new field dynatraceApiRequestsThreshold was added to the .spec of the Dynakube.
• a new field secCompProfile was added to relevant oneAgent sections: hostMonitoring, classicFullStack, cloudNativeFullstack

Please have a look at the tags if they are correct and also check my wording please.

Corresponding JIRA tickets: K8S-9331 and K8S-9492

Description

How can this be tested?

Take your time to:

• deploy operator
• try to query dynakubes
• test basic functionalities

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 48.53683% with 510 lines in your changes are missing coverage. Please review.

Project coverage is 58.09%. Comparing base (a54a20a) to head (dd478b5).
Report is 21 commits behind head on main.

❗ Current head dd478b5 differs from pull request most recent head 91a3d9e

Please upload reports for the commit 91a3d9e to get more accurate results.

Files	Patch %	Lines
pkg/api/v1beta2/dynakube/zz_generated.deepcopy.go	0.00%	182 Missing ⚠️
pkg/api/v1beta2/dynakube/properties.go	43.47%	139 Missing and 4 partials ⚠️
pkg/api/v1beta2/dynakube/dynakube_conversion.go	55.76%	36 Missing and 10 partials ⚠️
pkg/api/v1beta2/dynakube/feature_flags.go	57.14%	36 Missing ⚠️
pkg/api/v1beta2/dynakube/proxy.go	0.00%	25 Missing ⚠️
pkg/api/v1beta2/dynakube/certs.go	0.00%	19 Missing ⚠️
pkg/api/v1beta2/dynakube/dynakube_status.go	0.00%	17 Missing ⚠️
...ntrollers/dynakube/oneagent/daemonset/daemonset.go	50.00%	10 Missing ⚠️
...kg/controllers/dynakube/dynatraceclient/builder.go	0.00%	8 Missing ⚠️
pkg/controllers/dynakube/conditions.go	60.00%	3 Missing and 3 partials ⚠️
... and 12 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3092      +/-   ##
==========================================
- Coverage   59.25%   58.09%   -1.17%     
==========================================
  Files         319      324       +5     
  Lines       17446    17891     +445     
==========================================
+ Hits        10338    10393      +55     
- Misses       5941     6319     +378     
- Partials     1167     1179      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chrismuellner]

Just checking occurrences of v1beta1/v1alpha1 in the code base, I think we need to adapt a few more files:

• PROJECT has v1alpha1 and v1beta1 only
• troubleshoot package and command still use v1beta1
• v1alpha1 is still used in a bunch of places (can we completely remove it?)

[waodim]

Just checking occurrences of v1beta1/v1alpha1 in the code base, I think we need to adapt a few more files:

* `PROJECT` has `v1alpha1` and `v1beta1` only

* `troubleshoot` package and command still use `v1beta1`

* `v1alpha1` is still used in a bunch of places (can we completely remove it?)

• I updated PROJECT locally and will push soon
• In my opinion troubleshoot using v1beta1 is okay as it is our hub version now, or am I wrong there?
• I did not find usages of v1alpha1 version of the dynakube to be honest. When it comes to the whole v1alpha1 package we should not remove it in my opinion because of edgeconnect

[chrismuellner]

I would assume that all our logic should use the same, latest version of v1beta2.

I missed that the v1alpha1 package is required by edgeconnect, good point 😉

[0sewa0]

The conversion doesn't seem to work, when I create a v1beta1 DynaKube I get the following error:

Error from server: error when creating "./.vscode/deploy/dynakube_zib50933.yaml": admission webhook "webhook.dynatrace.com" denied the request: unable to decode dynatrace.com/v1beta1, Kind=DynaKube into *dynakube.DynaKube

Nothing in the logs.

I have been trying to fix it, introduced several changes but that did nothing.
The only relevant change is probably the missing version here, but that still didn't fix the issue

dynatrace-operator/config/helm/chart/default/templates/Common/webhook/validatingwebhookconfiguration.yaml

Line 38 in dd478b5

apiVersions:

[0sewa0]

I don't think this is correct as ParseDuration is actually smart and allows such things as 10h, but we only allow raw ints, that we use as seconds (I originally fought to use the actual ParseDuration, but it was deemed "to confusing" 🫤)

[0sewa0]

my attempts so far: 1990796

[waodim]

So basically you switched hub version if I see that correctly?

Thank you I will have a look and hopefully fix it

[0sewa0]

So basically you switched hub version

that was something I tried, it does not fix the problem

(I think its better to have the new version as the hub, if we are only using that in code, it should result in less conversions)

[0sewa0]

Rebased PR #3188 is already merged