Add e2e tests for custom truststore #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3023 +/- ##
=======================================
Coverage 58.68% 58.68%
=======================================
Files 325 325
Lines 18053 18053
=======================================
Hits 10595 10595
Misses 6284 6284
Partials 1174 1174 ☔ View full report in Codecov by Sentry. |
aorcholski
force-pushed
the
feature/truststore-e2e-test
branch
from
b830478
to
849b8fe
Compare
aorcholski
changed the title
aorcholski
force-pushed
the
feature/truststore-e2e-test
branch
3 times, most recently
from
1916f38
to
b36930e
Compare
aorcholski
changed the title
aorcholski
requested review from
gkrenn,
0sewa0,
chrismuellner,
albertogdd,
waodim,
StefanHauth and
luhi-DT
aorcholski
force-pushed
the
feature/truststore-e2e-test
branch
5 times, most recently
from
03da1ff
to
c71ef00
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
aorcholski
force-pushed
the
feature/truststore-e2e-test
branch
from
c71ef00
to
c285aac
Compare
|
OpenShift Cluster FAILED The custom truststore tests not executed: Error is unrelated to TestIstio: |
aorcholski
force-pushed
the
feature/truststore-e2e-test
branch
from
c285aac
to
30c081e
Compare
waodim
reviewed
May 2, 2024
aorcholski
force-pushed
the
feature/truststore-e2e-test
branch
2 times, most recently
from
94d0754
to
497ce67
Compare
aorcholski
force-pushed
the
feature/truststore-e2e-test
branch
6 times, most recently
from
a4db0a8
to
59a86cc
Compare
aorcholski
force-pushed
the
feature/truststore-e2e-test
branch
3 times, most recently
from
302683e
to
a3b1e55
Compare
aorcholski
force-pushed
the
feature/truststore-e2e-test
branch
from
a3b1e55
to
0e95586
Compare
albertogdd
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds e2e tests to verify propagation of trustedCAs certificates and ActiveGate certificate to OneAgent pods, ActiveGate and injected OneAgents.
All custom truststore specific tests are based on existing
cloudnative.WithProxy*features. There is no point in duplicating running time.How can this be tested?