Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add hybrid_score to trip model #346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhuijben
Copy link

Make the hybrid scrore available on the trip model.

(Tested with Toyota Corolla TS 2020)

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.58%. Comparing base (e8bd9d1) to head (16456fe).

Files Patch % Lines
mytoyota/models/trips.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
- Coverage   82.73%   82.58%   -0.16%     
==========================================
  Files          29       29              
  Lines        1413     1418       +5     
==========================================
+ Hits         1169     1171       +2     
- Misses        244      247       +3     
Flag Coverage Δ
unittests 82.58% <40.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CM000n
Copy link
Collaborator

CM000n commented Apr 18, 2024

Hello @rhuijben , thank you very much for your contribution!
Could you run pre-commit for the linting? Otherwise the PR looks good to me so far.

@rhuijben
Copy link
Author

I'll try. Not sure if the name should be score (api) or hybrid score (marketing)

Wouldn't be surprised if they use a different score for full hybrid

@rhuijben
Copy link
Author

poetry doesn't work on my FreeBSD machine where I use the library. But I ran it on a linux machine and fixed some whitespace. Followed the Toyota model and called it just score now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants