Skip to content

Merge pull request #151 from javachaos/javachaos-patch-1 #119

Merge pull request #151 from javachaos/javachaos-patch-1

Merge pull request #151 from javachaos/javachaos-patch-1 #119

GitHub Actions / clippy succeeded Mar 26, 2024 in 0s

clippy

6 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 6
Note 0
Help 0

Versions

  • rustc 1.77.0 (aedd173a2 2024-03-17)
  • cargo 1.77.0 (3fe68eabf 2024-02-29)
  • clippy 0.1.77 (aedd173 2024-03-17)

Annotations

Check warning on line 163 in src/loggers/testlog.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

single-character string constant used as pattern

warning: single-character string constant used as pattern
   --> src/loggers/testlog.rs:163:25
    |
163 |     let id = id.replace(")", "");
    |                         ^^^ help: consider using a `char`: `')'`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern

Check warning on line 103 in src/loggers/testlog.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/loggers/testlog.rs:103:29
    |
103 |     if should_skip(&config, &record) {
    |                             ^^^^^^^ help: change this to: `record`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 103 in src/loggers/testlog.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/loggers/testlog.rs:103:20
    |
103 |     if should_skip(&config, &record) {
    |                    ^^^^^^^ help: change this to: `config`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 80 in src/loggers/testlog.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value

warning: this let-binding has unit value
  --> src/loggers/testlog.rs:80:13
   |
80 |             let _ = log(&self.config, record);
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `log(&self.config, record);`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
   = note: `#[warn(clippy::let_unit_value)]` on by default

Check warning on line 36 in src/loggers/termlog.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `impl` can be derived

warning: this `impl` can be derived
  --> src/loggers/termlog.rs:32:1
   |
32 | / impl Default for TerminalMode {
33 | |     fn default() -> TerminalMode {
34 | |         TerminalMode::Mixed
35 | |     }
36 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
   = note: `#[warn(clippy::derivable_impls)]` on by default
   = help: remove the manual implementation...
help: ...and instead derive it...
   |
23 + #[derive(Default)]
24 | pub enum TerminalMode {
   |
help: ...and mark the default variant
   |
29 ~     #[default]
30 ~     Mixed,
   |

Check warning on line 218 in src/loggers/logging.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

single-character string constant used as pattern

warning: single-character string constant used as pattern
   --> src/loggers/logging.rs:218:25
    |
218 |     let id = id.replace(")", "");
    |                         ^^^ help: consider using a `char`: `')'`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
    = note: `#[warn(clippy::single_char_pattern)]` on by default