Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line ending enum to lib #152

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

javachaos
Copy link
Contributor

@javachaos javachaos commented Mar 26, 2024

I forgot to give public access to LineEnding struct, so that users could use it to define the desired line endings. E.g.

conf.set_line_ending(LineEnding::Crlf);

This commit allows users to:

use simplelog::LineEnding;

Copy link
Contributor Author

@javachaos javachaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit adds a for loop over the existing tests for each possible line ending. And asserts that the last line ending is accurate. Also, to deal with the large number of files created during test, it adds a folder named test_logs to store the generated test logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant