Adjust dependency to support termcolor 1.2 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a line to the CHANGELOG, but I’m not sure this is a big enough change to merit that. (I don’t care one way or another about being credited in the CHANGELOG — I just added the credit because it seemed to be the done thing.) |
The [1.2.0 update] to [termcolor] is backward compatible with the 1.1 versions. This adjusts the version specification for the dependency in Cargo.toml to allow any version greater than or equal to 1.1 and less than 2.0. [1.2.0 update]: BurntSushi/termcolor@1.1.3...1.2.0 [termcolor]: https://crates.io/crates/termcolor
|
Rebased. @Drakulix, you you prefer that this limit the termcolor version more? Happy to change it however. |
|
Ah sorry, I just missed this (always feel free to ping). Looks good to me. Thanks for putting in the time! I'll try to find time in the next couple of days to churn through the rest of the PRs and make a new release. |
|
Rad, thanks. No worries, it wasn’t a top priority. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1.2.0 update to termcolor is backward compatible with the 1.1 versions. This adjusts the version specification for the dependency in Cargo.toml to allow any version greater than or equal to 1.1 and less than 2.0.
This is preventing me from updating termcolor in a few of my crates. The update adds
Debugsupport to a bunch of types, so it’s kind of handy.I’d be happy to adjust the dependency specification however you like. Personally, I would not be concerned about the author releasing a breaking change without bumping the version past 2.0.