Merge pull request #3497 from bjornhellander/feature/sa1009cref

Updated SA1009 to forbid space after a closing parenthesis in a method reference contained in single quotes
DotNetAnalyzers · May 2, 2022 · 5143909 · 5143909
2 parents 528d635 + a668ee0
commit 5143909
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers.Test/SpacingRules/SA1009UnitTests.cs b/StyleCop.Analyzers/StyleCop.Analyzers.Test/SpacingRules/SA1009UnitTests.cs
@@ -85,6 +85,33 @@ public void Method()
             await VerifyCSharpFixAsync(testCode, expected, fixedCode, CancellationToken.None).ConfigureAwait(false);
         }
 
+        [Fact]
+        [WorkItem(2985, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/2985")]
+        public async Task TestDocumentationMethodReferenceInSingleQuotesWithWhitespaceAfterClosingParenthesisAsync()
+        {
+            const string testCode = @"
+public class Foo
+{
+    /// <see cref='Method({|#0:)|} '/>
+    public void Method()
+    {
+    }
+}";
+
+            const string fixedCode = @"
+public class Foo
+{
+    /// <see cref='Method()'/>
+    public void Method()
+    {
+    }
+}";
+
+            DiagnosticResult expected = Diagnostic(DescriptorNotFollowed).WithLocation(0);
+
+            await VerifyCSharpFixAsync(testCode, expected, fixedCode, CancellationToken.None).ConfigureAwait(false);
+        }
+
         [Fact]
         public async Task TestMethodWith2CorrectlySpacedParametersAsync()
         {

diff --git a/...nalyzers/StyleCop.Analyzers/SpacingRules/SA1009ClosingParenthesisMustBeSpacedCorrectly.cs b/...nalyzers/StyleCop.Analyzers/SpacingRules/SA1009ClosingParenthesisMustBeSpacedCorrectly.cs
@@ -118,6 +118,7 @@ private static void HandleCloseParenToken(SyntaxTreeAnalysisContext context, Syn
             case SyntaxKind.SemicolonToken:
             case SyntaxKind.CommaToken:
             case SyntaxKind.DoubleQuoteToken:
+            case SyntaxKind.SingleQuoteToken:
             case SyntaxKindEx.DotDotToken:
                 precedesStickyCharacter = true;
                 break;