Skip to content

Commit

Permalink
revert: Modal alignment to middle at breakpoint adjustment (#823)
Browse files Browse the repository at this point in the history
ref: 3aefefb
  • Loading branch information
rfgamaral committed May 3, 2024
1 parent 3aefefb commit a6142b8
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 16 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

Reactist follows [semantic versioning](https://semver.org/) and doesn't introduce breaking changes (API-wise) in minor or patch releases. However, the appearance of a component might change in a minor or patch release so keep an eye on redesigns and make sure your app still looks and feels like you expect it.

# v23.2.2

- [Fix] Revert "Adjust modal alignment to the middle of the viewport at `800px` breakpoint for improved UX". Turns out that this is not something that we want to do.

# v23.2.1

- [Fix] Adjust modal alignment to the middle of the viewport at `800px` breakpoint for improved UX.
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"email": "henning@doist.com",
"url": "http://doist.com"
},
"version": "23.2.1",
"version": "23.2.2",
"license": "MIT",
"homepage": "https://github.com/Doist/reactist#readme",
"repository": {
Expand Down
16 changes: 3 additions & 13 deletions src/modal/modal.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@
.overlay.fitContent > [data-focus-lock-disabled] {
padding-top: var(--reactist-modal-padding-top);
}
.overlay.fitContent > [data-focus-lock-disabled] .container {
max-height: calc(100vh - 2 * var(--reactist-modal-padding-top));
}

.container {
box-shadow: 0px 2px 8px 0px rgba(0, 0, 0, 0.16);
Expand Down Expand Up @@ -115,19 +118,6 @@
}
}

@media (min-height: 800px) {
.overlay.fitContent > [data-focus-lock-disabled] .container {
max-height: calc(100vh - 2 * var(--reactist-modal-padding-top));
}
}

@media (max-height: 800px) {
.overlay.fitContent > [data-focus-lock-disabled] {
padding-top: var(--reactist-spacing-xxlarge);
justify-content: center;
}
}

/* header */

.buttonContainer {
Expand Down

0 comments on commit a6142b8

Please sign in to comment.