New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rollup output export options to 1.0+ syntax #151

Merged

eshtadc merged 1 commit into DockYard:master from minusfive:update-rollup-exports

Apr 12, 2019

Contributor

minusfive commented Apr 8, 2019

https://github.com/DockYard/ember-service-worker/blob/master/lib/service-worker-builder.js#L107 emmits the following Rollup deprecation notice:

The following options have been renamed — please update your config: exports -> output.exports

Because Rollup moved the options.exports to options.output.exports on 1.0, as stated on this PR: rollup/rollup#2293.

Moving the exports setting accordingly removes the warning.

I did not think new/modified tests were necessary for this change (?).


          Update rollup output export options to 1.0+ syntax

b52d040

eshtadc approved these changes

View reviewed changes

Contributor

eshtadc left a comment

Thank you @minusfive

eshtadc merged commit 4f97960 into DockYard:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment