[BUG] update scroll position should only be called once #242
+82
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
commented
Feb 25, 2020
addon/index.js
Outdated
| } else { | ||
| // as described in ember-app-scheduler, this addon can be used to delay rendering until after the route is idle | ||
| whenRouteIdle().then(CALLBACK.bind(this, transition)); | ||
| whenRouteIdle().then(() => { |
There was a problem hiding this comment.
Need some sort of deferred queue that allows this case to be updated with latest
snewcomer
changed the title
Ravenstine
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
routeDidChangeis called more than once indeterminately.scheduleOncewill run once IFF the same callback ref is given to it. This PR fixes that and is the easy part of this PR.The difficult part of this PR -
whenRouteIdleneeds to be resolved and scroll position updated when we are done callingrouteDidChange. Effectively the last call is the last argument. We don't want to update the scroll position somewhere in the middle. So the difficult part of this is when to resolve. We do this withrequestAnimationFrameand a counter.In algorithmic terms, this is a stack (and more like a deferred stack because the producer of the items does not know when it done pushing new items onto the stack. It only attempts to pop the last item from the stack when it is done pushing new items on the stack and an arbitrary count gets back to 0).