Fix/#98 find loaders path separator agnostically #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was using Ubuntu hosted in WSL with a project originally created on Windows. I was actually running the project from Git for Windows (so, in Windows). This resulted in some issues for craco-less. Craco-less attempted to find loaders by first ascertaining the path separator which should be used. So in Ubuntu in WSL, that would be `/` since that's Linux. However, the project was installed and being run from Windows, so the standard path separator is (usually) `\` (though, PowerShell will work just fine with either `/` or `\`). But, why should craco-less bother to match _exactly_ the path separator being used to find a loader? It's unnecessary and brittle. Just so long as the loader name appears between path separators should be good enough. Heck, even `\<loader-name>/` shouldn't _really_ be a problem. And even if it were, I'd be less worried about craco-less than something else in my build toolchain failing as a result, at which time I would then correct the issue. So again, matching against an exact path separator is more complex, brittle, and unnecessary. This commit replaces the searching logic with a function which uses amap of loader name to regular expressions so that special-case path separator logic is not required.
kamronbatman
force-pushed
the
fix/#98-find-loaders-path-separator-agnostically
branch
from
8376508
to
87f1e05
Compare
|
I rebased your changes into master. Looks like it needs test updates. |
kamronbatman
approved these changes
Jul 8, 2023
|
Awesome, thanks, I appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98.
Closes #84
Find Webpack CSS loaders using platform-independent path-separator logic.