Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organizing code #4

Merged
merged 3 commits into from
Jan 27, 2022
Merged

Re-organizing code #4

merged 3 commits into from
Jan 27, 2022

Conversation

rcaneill
Copy link
Collaborator

  1. Organizing code in a cleaner way
  2. Add a 1st simple test

Comment on the test test_func_standard_module: it fails. This means that gsw can only be used when importing function from gsw, and not from the modules (like from gsw.density import sigma0). This is a problem.

@rcaneill rcaneill changed the title Rc dev orga Re-organizing code Jan 25, 2022
@rcaneill
Copy link
Collaborator Author

I changed poetry.lock to use python 3.8 (I don't use python3.9 installed yet), I guess all what we do may even be compatible with python 3.6?

@DocOtak
Copy link
Owner

DocOtak commented Jan 26, 2022

Xarray recently dropped support for python 3.7, so we should stick with that as the minimum "supported" python version.

Since #5 will probably require that we maintain some sort separation between the xarray specific and upstream public API, I think I like the approach of having the single underscore "mark as private" our stuff.

Was the poetry.lock file regenerated by poetry itself? as in you only modified the pyproject.toml file then poetry remade that lock file (I don't know what the best practice is yet for dealing with this lock file)

@rcaneill
Copy link
Collaborator Author

I did not knew about the drop for python 3.7. So it makes sense then to support >=3.8 now.

Yes I only changed pyproject.toml and poetry updated the poetry.lock file. I don't know neither the best practice. I am more used to using a setup.py file for library installation, and pipenv files for dev / tests.

@rcaneill rcaneill requested a review from DocOtak January 27, 2022 07:45
@DocOtak DocOtak merged commit 7c0433c into DocOtak:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants