Merge pull request #1025 from DoSomething/eslint

Cache helper test + eslint update

.eslintrc

@@ -1,5 +1,5 @@
 ---
-  extends: "@dosomething/eslint-config"
+  extends: "@dosomething/eslint-config/nodejs/6.x"
   globals:
     app: true
   parserOptions:

app/exceptions/ClosedCampaignError.js

@@ -1,12 +1,10 @@
 'use strict';
 
 class ClosedCampaignError extends Error {
-
   constructor(phoenixCampaign) {
     super();
     this.message = `Campaign ${phoenixCampaign.id} is closed.`;
   }
-
 }
 
 module.exports = ClosedCampaignError;

app/exceptions/UnprocessibleEntityError.js

@@ -1,12 +1,10 @@
 'use strict';
 
 class UnprocessibleEntityError extends Error {
-
   constructor(message) {
     super(message);
     this.status = 422;
   }
-
 }
 
 module.exports = UnprocessibleEntityError;

lib/contentful.js

@@ -72,8 +72,8 @@ module.exports.fetchSingleEntry = function fetchSingleEntry(query) {
   return new Promise((resolve, reject) => {
     logger.debug(`contentful.fetchSingleEntry:${JSON.stringify(query)}`);
     return exports.getClient().getEntries(query)
-    .then(entries => resolve(underscore.first(entries.items)))
-    .catch(error => reject(exports.contentfulError(error)));
+      .then(entries => resolve(underscore.first(entries.items)))
+      .catch(error => reject(exports.contentfulError(error)));
   });
 };
 
@@ -109,8 +109,8 @@ module.exports.fetchKeywords = function fetchKeywords() {
     .environment(process.env.NODE_ENV)
     .build();
   return exports.getClient().getEntries(query)
-  .then(response => response.items.map(item => exports.formatKeywordFromResponse(item)))
-  .catch(error => exports.contentfulError(error));
+    .then(response => response.items.map(item => exports.formatKeywordFromResponse(item)))
+    .catch(error => exports.contentfulError(error));
 };
 
 module.exports.fetchKeywordsForCampaignId = function (campaignId) {

lib/middleware/timeouts.js

@@ -22,7 +22,7 @@ module.exports.injectTimeoutString = function injectTimeoutString(req, res, next
   next();
 };
 
- // Set respond to false so we can send our own 504 status.
- // Note: Our routes will need to check for req.timedout.
- // @see https://github.com/expressjs/timeout/tree/v1.8.0#api
+// Set respond to false so we can send our own 504 status.
+// Note: Our routes will need to check for req.timedout.
+// @see https://github.com/expressjs/timeout/tree/v1.8.0#api
 module.exports.timedout = timeout(`${getTimeoutNumSeconds()}s`, { respond: false });

lib/tools/profiler.js

@@ -7,7 +7,6 @@ const EventEmitter = require('events');
  * The Profiler
  */
 class Profiler extends EventEmitter {
-
   /**
    * Create a new Profiler.
    *

lib/tools/uploader.js

@@ -7,7 +7,6 @@ const s3Stream = require('s3-upload-stream');
  * The S3Uploader class.
  */
 class S3Uploader {
-
   /**
    * Create a new S3Uploader
    *