This repository has been archived by the owner on Jan 29, 2021. It is now read-only.
All laravel upgrades #1080
Merged
All laravel upgrades #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avel provides same method.
…ack webhook in PHPUnit settings.
* Updating composer packages. * Updating dependencies. * Removing unused files and updating index.php * Updating .htaccess. * Removing bootstrap/autoload call. * Updating TrustedProxy settings. * Removing mentions of Dusk in project since no longer used. * Upadating Hashing config. * Updating Logging. * Updating logger method name. * Bringing rest of files up to date and in sync with 5.6 framework files. * Reverting web routes file I was using for debugging. * Figuring out issues with running tests. * Updating composer. * StyleCI fix. * Updating dependencies for 5.7. * Updating assets. * Updating authorization. * Updating cache. * Updating tests. * Removing overridden mock() method since the signature changed and Laravel provides same method. * Removing unused imported class. * Removing CustomGate now that framework supports Guest User Gates. * Fixing up broken tests. * Composer lock update. * Wrapping up miscellaneous updates from 5.6 to 5.7. * Some miscellaneous updates from 5.7 to 5.8. * Updating dependencies and fixing API routes. * Updating testing. * Updating notifications. * Updating support. * Updating support with env() changes. * Updating env example vars. * Updates to env vars used and simplifying redis env settings. * Fixing up Tag tests and errors with notifications. * Updating cache config. * Removing deleted_at from array since automatically converted after upgrades. * Changing tag so it does not trigger notification, if not point of test. * Cleanup. * Fixing StyleCI issue. * StyleCI fixes. * StyleCI fixes. * Updating Trusted Proxies based on Heroku docs. * Type-hinting the Authenticateable class works. * Updating redis options. * Updating filesystems config and reivew app config. * Adding note regarding a potential future update. * Restoring the Good Submission tag and setting empty string var for slack webhook in PHPUnit settings. * Restoring old approach now that tests do not trigger notifications. * Updaing AWS_* env variables.
weerd
force-pushed
the
all-laravel-upgrades
branch
from
e1a1a68
to
ad4ef05
Compare
* Removing CustomGate now that framework supports Guest User Gates. * Updating support. * Rebase fixes. * Rebase fixes. * Upgrading Laravel Framework (#1071) * Updating composer packages. * Updating dependencies. * Removing unused files and updating index.php * Updating .htaccess. * Removing bootstrap/autoload call. * Updating TrustedProxy settings. * Removing mentions of Dusk in project since no longer used. * Upadating Hashing config. * Updating Logging. * Updating logger method name. * Bringing rest of files up to date and in sync with 5.6 framework files. * Reverting web routes file I was using for debugging. * Figuring out issues with running tests. * Updating composer. * StyleCI fix. * Updating dependencies for 5.7. * Updating assets. * Updating authorization. * Updating cache. * Updating tests. * Removing overridden mock() method since the signature changed and Laravel provides same method. * Removing unused imported class. * Removing CustomGate now that framework supports Guest User Gates. * Fixing up broken tests. * Composer lock update. * Wrapping up miscellaneous updates from 5.6 to 5.7. * Some miscellaneous updates from 5.7 to 5.8. * Updating dependencies and fixing API routes. * Updating testing. * Updating notifications. * Updating support. * Updating support with env() changes. * Updating env example vars. * Updates to env vars used and simplifying redis env settings. * Fixing up Tag tests and errors with notifications. * Updating cache config. * Removing deleted_at from array since automatically converted after upgrades. * Changing tag so it does not trigger notification, if not point of test. * Cleanup. * Fixing StyleCI issue. * StyleCI fixes. * StyleCI fixes. * Updating Trusted Proxies based on Heroku docs. * Type-hinting the Authenticateable class works. * Updating redis options. * Updating filesystems config and reivew app config. * Adding note regarding a potential future update. * Restoring the Good Submission tag and setting empty string var for slack webhook in PHPUnit settings. * Restoring old approach now that tests do not trigger notifications. * Updaing AWS_* env variables. * Miscellaneous updates. * Updating miscellaneous. * Composer dependency updates. * Updating configuration. * Updating PHPUnit and fixing test with previously deprecated method. * Updating composer dependencies. * Reordering. * Cleanup. * Prefixing the SQS Env vars with AWS_ for consistency. * Post rebase cleanup * Fixing straggling merge conflicts. * Cleanup. * Updating url and endpoint settings.
weerd
requested review from
Dinnall and
DFurnes
and removed request for
a team and
Dinnall
3 tasks
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
This pull request finalizes the full Rogue updates, collecting and wrapping up the changes from Laravel 5.8 to 6.0. 🎉
How should this be reviewed?
Already been reviewed in the #1071 and #1081
Any background context you want to provide?
🌵
Relevant tickets
References Pivotal #172383643.
Checklist