Use RESTRICT_ON_SEND
#141
Merged
Use RESTRICT_ON_SEND
#141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up rubocop/rubocop#8365. This PR uses `RESTRICT_ON_SEND` to restrict callbacks `on_send` to specific method names only. https://docs.rubocop.org/rubocop/1.52/development.html#implementation `RESTRICT_ON_SEND` has been introduced since RuboCop 0.90, so it bumps the required lowest runtime RuboCop dependency from 0.87 to 0.90. No runtime Ruby version incompatibilities between 0.87 and 0.90: https://docs.rubocop.org/rubocop/1.52/compatibility.html
koic
force-pushed
the
use_restrict_on_send
branch
from
a0d1cc5
to
e9fc652
Compare
|
Thank you 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up rubocop/rubocop#8365.
This PR uses
RESTRICT_ON_SENDto restrict callbackson_sendto specific method names only. https://docs.rubocop.org/rubocop/1.52/development.html#implementationRESTRICT_ON_SENDhas been introduced since RuboCop 0.90, so it bumps the required lowest runtime RuboCop dependency from 0.87 to 0.90. No runtime Ruby version incompatibilities between 0.87 and 0.90: https://docs.rubocop.org/rubocop/1.52/compatibility.html