Merge pull request #715 from DirectoryTree/BUG-714

Bug 714 - Reverse boolean casts no longer accept LDAP string booleans
DirectoryTree · May 8, 2024 · d7c698e · d7c698e
2 parents 999f6ad + 7b785db
commit d7c698e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/Models/Concerns/HasAttributes.php b/src/Models/Concerns/HasAttributes.php
@@ -578,8 +578,12 @@ protected function asBoolean(mixed $value): bool
     /**
      * Cast the value from a primitive boolean to an LDAP boolean string.
      */
-    protected function fromBoolean(bool $value): string
+    protected function fromBoolean(mixed $value): string
     {
+        if (is_string($value)) {
+            $value = $this->asBoolean($value);
+        }
+
         return $value ? 'TRUE' : 'FALSE';
     }
 

diff --git a/tests/Unit/Models/ModelAttributeCastTest.php b/tests/Unit/Models/ModelAttributeCastTest.php
@@ -28,6 +28,10 @@ public function test_boolean_attributes_are_casted()
         $this->assertTrue($model->booleanAttribute);
         $this->assertEquals($model->getRawAttribute('booleanAttribute'), ['TRUE']);
 
+        $model->booleanAttribute = 'false';
+        $this->assertFalse($model->booleanAttribute);
+        $this->assertEquals($model->getRawAttribute('booleanAttribute'), ['FALSE']);
+
         // Casing differences
 
         $model = (new ModelCastStub)->setRawAttributes(['boolAttribute' => ['true']]);