Code changes refined microsoft#958

DineshChirnanchu · Sep 16, 2019 · c291d2d · c291d2d
1 parent 65418b7
commit c291d2d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 14 deletions.
diff --git a/src/Microsoft.TestPlatform.Common/Constants.cs b/src/Microsoft.TestPlatform.Common/Constants.cs
@@ -66,15 +66,5 @@ public static class TestPlatformConstants
         /// Pattern used to find the run time providers library using String.EndWith
         /// </summary>
         public const string RunTimeEndsWithPattern = @"RuntimeProvider.dll";
-
-        /// <summary>
-        /// entensionTypeInfo lists the type info of extensions
-        /// </summary>
-        public static readonly  IList<string> entensionTypeInfo = new List<string>()
-        {
-            {"TestExecutorPluginInformation"},
-            {"TestDiscovererPluginInformation"},
-            {"TestSettingsProviderPluginInformation"}
-        };
     }
 }
diff --git a/src/Microsoft.TestPlatform.CrossPlatEngine/Discovery/DiscovererEnumerator.cs b/src/Microsoft.TestPlatform.CrossPlatEngine/Discovery/DiscovererEnumerator.cs
@@ -166,7 +166,7 @@ private void LoadTestsFromAnExtension(string extensionAssembly, IEnumerable<stri
 
                 if (this.discoveryResultCache.TotalDiscoveredTests == 0)
                 {
-                    LogWarningOnNoTestsDiscovered(sources, testCaseFilter, logger);
+                        LogWarningOnNoTestsDiscovered(sources, testCaseFilter, logger);
                 }
             }
             finally
@@ -316,9 +316,8 @@ private static void LogWarningOnNoTestsDiscovered(IEnumerable<string> sources, s
             }
             else
             {
-                logger.SendMessage(
-                    TestMessageLevel.Warning,
-                    string.Format(
+                //Should be logged only when tests found - if adapter failed to load then there would be no tests to process
+                EqtTrace.Warning(string.Format(
                         CultureInfo.CurrentUICulture,
                         CrossPlatEngineResources.TestRunFailed_NoDiscovererFound_NoTestsAreAvailableInTheSources,
                         sourcesString));