Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: migrating rules to eslint9 #100

Closed
wants to merge 2 commits into from
Closed

Conversation

DianaSuvorova
Copy link
Owner

@DianaSuvorova DianaSuvorova commented Apr 28, 2024

also eslint-plugin-airbnb migration to v9 is in progress airbnb/javascript#2961 so the cod is not linted properly.

So all and all we are quite early to the party.

Update: I don't think we can release until the rest of the deps release v9 support. So this branch will stay as a POC. I don't want to force override peer dep requirements, so this branch will stay as a POC and will wait for the rest of the eco system to catch up.

@ljharb
Copy link
Collaborator

ljharb commented Apr 29, 2024

Why does it need to be a breaking change?

@DianaSuvorova
Copy link
Owner Author

@ljharb It hopefully does not have to be. Currently to migrate to eslint 9 I need to deprecate/exclue no-unused-prop-types rule since it depends on the code from eslint-plugin-react. And this fails on eslint 9. So I'll wait for the eslint-plugin-react to adopt v9. Ended up creating this pr as a POC but I will not be merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants