eslint-plugin-import

[bhollis]

This sets up eslint-plugin-import. Most of its rules are redundant with normal build errors, but this adds a few interesting ones. I've fixed all except the no-cycle errors, of which we have 123. We can maybe chip away at them here?

[robojumper]

Hm, some of these imports import only types, so they're not actually a real dependency for bundling / module loading. The workaround seems to be enabling @typescript-eslint/consistent-type-imports and turning all of these into import type statements...

[robojumper]

See eslint-import...robojumper:DIM:eslint-import for import type. Apparently const enums, even with the const enum optimization, are still detected as a dependency for module importing, which seems incorrect to me and makes some of these more annoying than they need to be.

[bhollis]

Gotcha. I figured we'd want to turn on the type imports at some point, but they really don't offer much of any value outside of this.

[robojumper]

Looked some more at the const enum thing. TypeScript is vaguely in favor of allowing import type { SomeConstEnum } microsoft/TypeScript#42991 but haven't accepted the feature yet. It seems https://github.com/import-js/eslint-import-resolver-typescript is able to provide more accurate import info without import type? But I guess it doesn't solve the const enum thing... From import-js/eslint-plugin-import#2267

[bhollis]

At the end of the day this is what's stopped me from using this plugin in the past - it has to recreate all the knowledge that both TypeScript and Webpack have in order to make sense of things.