Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split of publish workflow #157

Merged
merged 3 commits into from
May 28, 2022

Conversation

k3rnelpan1c-dev
Copy link
Contributor

Description

This PR picks up the idea from the backend CI and aims to fix the incorrect version reported by the releases originated from the current CI.

Changes

  • splits off publish build to a separate workflow

Issues

picks up the idea from the backend CI and fixes the incorrect version released by the current CI

Signed-off-by: K3rnelPan1c <69395733+k3rnelpan1c-dev@users.noreply.github.com>
Signed-off-by: K3rnelPan1c <69395733+k3rnelpan1c-dev@users.noreply.github.com>
@k3rnelpan1c-dev k3rnelpan1c-dev marked this pull request as ready for review May 27, 2022 17:33
Signed-off-by: K3rnelPan1c <69395733+k3rnelpan1c-dev@users.noreply.github.com>
@nscuro
Copy link
Member

nscuro commented May 27, 2022

Thanks for yet another great PR, @k3rnelpan1c-dev! Can we adopt the release branch handling from the API server workflows as well? There are some features scheduled for 4.6, but we may need to push out another 4.5.x release in the meantime.

@nscuro nscuro added the ci label May 27, 2022
@k3rnelpan1c-dev
Copy link
Contributor Author

So you want to have release branches for the frontend repo?
I sure can port the handling over, will try and do that over the weekend maybe 🤔

@nscuro
Copy link
Member

nscuro commented May 28, 2022

That'd be awesome. I'm going to merge this PR now though, as supporting release branches would be a separate feature I guess. 😅

@nscuro nscuro merged commit 7845d41 into DependencyTrack:master May 28, 2022
@k3rnelpan1c-dev
Copy link
Contributor Author

That'd be awesome. I'm going to merge this PR now though, as supporting release branches would be a separate feature I guess. sweat_smile

Sounds good to me :)

On a different note: saw that there will be a BOT user soon 👍 Just my 2 cents, but I recommend configuring that secret with its PAT on the org level and granting access to it on a repo per repo basis => only one place to maintain it 😉

@k3rnelpan1c-dev k3rnelpan1c-dev deleted the fix/release-workflow branch May 28, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants