Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIWO-815: Update dependencies #421

Merged

Conversation

lsarni
Copy link
Contributor

@lsarni lsarni commented Jul 6, 2023

Ticket: LIWO-815

Dependencies listed on first page of excel file:

  • High

    • @vue-a11y/skip-to: current version is already last version, 2.1.2
    • vue: Moving to vue 3 introduces a lot of breaking changes
    • vuex: Related to moving to vue 3
  • Medium

    • proj4leaflet: current version is already last version, 1.0.2
    • proxy-polyfill: current version is already last version, 3.0.2
    • dom-to-image: current version is already last version, 2.6.0
    • leaflet-easyprint: current version is already last version, 2.1.9
    • portal-vue: current version, 2.1.7, is already last version available for Vue 2. The newest version works for Vue 3.
    • url-search-params: uninstalled as it wasn’t being used, we are using url-search-params-polyfill
    • vue-cookie-law: current version is already last version, 1.13.3
    • vue-head: current version is already last version, 2.2.0

All the dependencies are old, 3 to 6 years, but there are no never version so it's not possible to upgrade them to fix the issue.

Dependencies that appear on the screenshot:

  • High:

    • focus-trap: updated from 6.7.2 to latest 7.5.2
    • leaflet: update from 1.7.1 to latest 1.9.4
    • leaflet.browser.print: can't be updated to a higher version because it breaks this test. It seems to work correctly, but on the test the stub of the print doesn't work which opens the print dialog and gets the test stuck.
    • promise-polyfill: removed since it’s no longer used on the code since PR #51
    • vue: Moving to vue 3 introduces a lot of breaking changes
    • vue-router: Related to moving to vue 3
    • vuex: Related to moving to vue 3
  • Medium

@lsarni lsarni force-pushed the fix/liwo-815-update-dependencies branch from fccdc4a to 7c7118e Compare July 6, 2023 13:04
@lsarni lsarni force-pushed the fix/liwo-815-update-dependencies branch from 6ed1462 to 3e31060 Compare July 7, 2023 10:03
@lsarni lsarni force-pushed the fix/liwo-815-update-dependencies branch from 3e31060 to 498399a Compare July 7, 2023 12:22
@lsarni lsarni force-pushed the fix/liwo-815-update-dependencies branch from 0ee7317 to 35cb16e Compare July 7, 2023 13:19
@sonarcloud
Copy link

sonarcloud bot commented Jul 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lsarni lsarni marked this pull request as ready for review July 10, 2023 09:28
@sjoerdbeentjes sjoerdbeentjes merged commit 1809305 into Deltares-research:master Jul 13, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants