feat(express-serve-static-core): Add Layer typings to express Router & Route stack prop

[douglasg14b]

Relevant source for Layer:

• Layer source: https://github.com/expressjs/express/blob/master/lib/router/layer.js#L142
• Router Usage for route property: https://github.com/expressjs/express/blob/
  4b9cd2fd0e13519a16bc36e8b4212e7924698b2e/lib/router/index.js#L227
  • route assignment: https://github.com/expressjs/express/blob/4b9cd2fd0e13519a16bc36e8b4212e7924698b2e/lib/router/index.js#L511
  • route assignment to undefined: https://github.com/expressjs/express/blob/4b9cd2fd0e13519a16bc36e8b4212e7924698b2e/lib/router/index.js#L481
• Route stack prop: https://github.com/expressjs/express/blob/4b9cd2fd0e13519a16bc36e8b4212e7924698b2e/lib/router/route.js#L200
• Router stack prop: https://github.com/expressjs/express/blob/4b9cd2fd0e13519a16bc36e8b4212e7924698b2e/lib/router/index.js#L513

---

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run pnpm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <>
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

[typescript-bot]

@douglasg14b Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• express-serve-static-core — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 13 days — please try to get reviewers!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69539,
  "author": "douglasg14b",
  "headCommitOid": "e17eed1e4f5ebf351fa09e6971f6dae0844b00d5",
  "mergeBaseOid": "d74e847b9f94d5b7d6fbc5d754a84465d52bdeed",
  "lastPushDate": "2024-05-06T23:01:46.000Z",
  "lastActivityDate": "2024-05-06T23:30:56.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "express-serve-static-core",
      "kind": "edit",
      "files": [
        {
          "path": "types/express-serve-static-core/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "borisyankov",
        "micksatana",
        "samijaber",
        "JoseLion",
        "dwrss",
        "andoshin11"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2097069294,
  "ciResult": "pass"
}

[typescript-bot]

Hey @douglasg14b,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

[typescript-bot]

🔔 @borisyankov @micksatana @samijaber @JoseLion @dwrss @andoshin11 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@douglasg14b The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[douglasg14b]

This PR appears to be similar (Though with extraneous format changes), but was closed: #63329

Unsure how to add tests for this, I did this entirely on github and did not pull the repo. These typings are not that complex, and are pulled from what I could gleam of the source.

[typescript-bot]

@douglasg14b The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[DangerBotOSS]

Formatting

The following files are not formatted:

1. types/express-serve-static-core/index.d.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against e17eed1

[typescript-bot]

Re-ping @borisyankov, @micksatana, @samijaber, @JoseLion, @dwrss, @andoshin11:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!