Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint: tweak documentation for rule meta properties #68619

Merged

Conversation

bmish
Copy link
Contributor

@bmish bmish commented Feb 13, 2024

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

Tweak documentation based on real-world usage of these ESLint rule properties. Especially, this clarifies how properties are commonly used.

Similar change I made in the ESLint repository:

Follow-up to a previous change I made to tweak this documentation:

Relevant RFC about schemas becoming mandatory in the soon-to-be-released ESLint v9:

@bmish bmish changed the title eslint: tweak documentation for rule meta.docs properties eslint: tweak documentation for rule meta properties Feb 13, 2024
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 13, 2024

@bmish Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 68619,
  "author": "bmish",
  "headCommitOid": "d6f2f05a91a2fadac58613a21b9e1e9e830ea772",
  "mergeBaseOid": "8beea70823af10e72a62883b0a525ebe4587c755",
  "lastPushDate": "2024-02-13T21:35:07.000Z",
  "lastActivityDate": "2024-02-22T22:08:11.000Z",
  "mergeOfferDate": "2024-02-22T22:05:19.000Z",
  "mergeRequestDate": "2024-02-22T22:08:11.000Z",
  "mergeRequestUser": "bmish",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "eslint",
      "kind": "edit",
      "files": [
        {
          "path": "types/eslint/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "pmdartus",
        "j-f1",
        "saadq",
        "JasonHK",
        "bradzacher",
        "JounQin"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2024-02-22T22:04:39.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "bradzacher",
      "date": "2024-02-13T21:41:46.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1942646984,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Untested Change This PR does not touch tests labels Feb 13, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Feb 13, 2024
@typescript-bot
Copy link
Contributor

Hey @bmish,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Contributor

🔔 @pmdartus @j-f1 @saadq @JasonHK @bradzacher @JounQin — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Feb 13, 2024
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Feb 13, 2024
@typescript-bot
Copy link
Contributor

⏳ Hi @bmish,

It's been a few days since this PR was approved by bradzacher and we're waiting for a DT maintainer to give a review.

If you would like to short-circuit this wait, you can edit some of the test files in the package which verify how the .d.ts files work. This would allow the PR to be merged by you or the DT module owners after a re-review.

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Feb 22, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Feb 22, 2024
@typescript-bot
Copy link
Contributor

@bmish: Everything looks good here. I am ready to merge this PR (at d6f2f05) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@pmdartus, @j-f1, @saadq, @JasonHK, @bradzacher, @JounQin: you can do this too.)

@bmish
Copy link
Contributor Author

bmish commented Feb 22, 2024

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Feb 22, 2024
@typescript-bot typescript-bot merged commit 3977ab3 into DefinitelyTyped:master Feb 22, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants