Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[types/validator] Add new supported UUID versions 1 and 2 #65406

Conversation

thefat32
Copy link
Contributor

@thefat32 thefat32 commented May 5, 2023

New UUID versions 1 and 2 are now supported since 13.0.7 (validatorjs/validator.js#1848)

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: link
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header. (not new version)

New UUID versions 1 and 2 are now supported since 13.0.7
(validatorjs/validator.js#1848)
@typescript-bot
Copy link
Contributor

typescript-bot commented May 5, 2023

@thefat32 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 65406,
  "author": "thefat32",
  "headCommitOid": "5a4a2c0eccbbf8840787d6c4f7efef34bfa3adc9",
  "mergeBaseOid": "80908e3bef3bb789d841104d5719f56e155a70ff",
  "lastPushDate": "2023-05-05T00:22:48.000Z",
  "lastActivityDate": "2023-05-05T22:42:49.000Z",
  "mergeOfferDate": "2023-05-05T20:20:24.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "validator",
      "kind": "edit",
      "files": [
        {
          "path": "types/validator/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tgfjt",
        "chrootsu",
        "IOAyman",
        "louy",
        "deptno",
        "builtinnya",
        "qqilihq",
        "keatz55",
        "MunifTanjim",
        "vlapo",
        "peterblazejewicz",
        "Mattewn99",
        "Almost-Infinity",
        "dcfreire"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2023-05-05T20:19:38.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1535554774,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Untested Change This PR does not touch tests labels May 5, 2023
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 5, 2023
@typescript-bot
Copy link
Contributor

🔔 @tgfjt @chrootsu @IOAyman @louy @deptno @builtinnya @qqilihq @keatz55 @MunifTanjim @vlapo @peterblazejewicz @Mattewn99 @Almost-Infinity @dcfreire — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 5, 2023
Copy link
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!
@thefat32 thanks!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels May 5, 2023
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board May 5, 2023
@lpicchi
Copy link

lpicchi commented May 5, 2023

Ready to merge

@peterblazejewicz peterblazejewicz merged commit 5a6ffa3 into DefinitelyTyped:master May 6, 2023
2 checks passed
@typescript-bot typescript-bot removed this from Waiting for Author to Merge in New Pull Request Status Board May 6, 2023
Desplandis pushed a commit to Desplandis/DefinitelyTyped that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants