New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[types/validator] Add new supported UUID versions 1 and 2 #65406
[types/validator] Add new supported UUID versions 1 and 2 #65406
Conversation
New UUID versions 1 and 2 are now supported since 13.0.7 (validatorjs/validator.js#1848)
@thefat32 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 65406,
"author": "thefat32",
"headCommitOid": "5a4a2c0eccbbf8840787d6c4f7efef34bfa3adc9",
"mergeBaseOid": "80908e3bef3bb789d841104d5719f56e155a70ff",
"lastPushDate": "2023-05-05T00:22:48.000Z",
"lastActivityDate": "2023-05-05T22:42:49.000Z",
"mergeOfferDate": "2023-05-05T20:20:24.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "validator",
"kind": "edit",
"files": [
{
"path": "types/validator/index.d.ts",
"kind": "definition"
}
],
"owners": [
"tgfjt",
"chrootsu",
"IOAyman",
"louy",
"deptno",
"builtinnya",
"qqilihq",
"keatz55",
"MunifTanjim",
"vlapo",
"peterblazejewicz",
"Mattewn99",
"Almost-Infinity",
"dcfreire"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2023-05-05T20:19:38.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1535554774,
"ciResult": "pass"
} |
🔔 @tgfjt @chrootsu @IOAyman @louy @deptno @builtinnya @qqilihq @keatz55 @MunifTanjim @vlapo @peterblazejewicz @Mattewn99 @Almost-Infinity @dcfreire — please review this PR in the next few days. Be sure to explicitly select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT!
@thefat32 thanks!
Ready to merge |
…Typed#65406) New UUID versions 1 and 2 are now supported since 13.0.7 (validatorjs/validator.js#1848)
New UUID versions 1 and 2 are now supported since 13.0.7 (validatorjs/validator.js#1848)
Please fill in this template.
npm test <package to test>
.If changing an existing definition: