Remove onFinishCommand

[wemeetagain]

Please fill in this template.

See https://github.com/yargs/yargs/blob/2e0ef3c965dd788ec4af0735ce96d66ed9f91cc0/CHANGELOG.md
and yargs/yargs#1823

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: feat!: improve support for async/await yargs/yargs#1823
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@wemeetagain Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• yargs — on npm, on unpkg
  • owner-approval: @forivall

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 31 days — closed because it wasn't merged for a long time!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 64391,
  "author": "wemeetagain",
  "headCommitOid": "4f4e3242f566f42fda5ffcb8bc22e09fc4303a98",
  "mergeBaseOid": "522b1bea375ca56de1240be51ef2b3deac4c9ef5",
  "lastPushDate": "2023-02-16T17:05:47.000Z",
  "lastActivityDate": "2023-03-13T19:44:36.000Z",
  "mergeOfferDate": "2023-03-13T19:45:22.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "yargs",
      "kind": "edit",
      "files": [
        {
          "path": "types/yargs/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "poelstra",
        "mizunashi-mana",
        "pushplay",
        "JimiC",
        "steffenvv",
        "forivall",
        "ExE-Boss",
        "Aankhen",
        "bcoe"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2023-03-13T19:44:36.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "forivall",
      "date": "2023-03-02T01:43:18.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1433436570,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @poelstra @mizunashi-mana @pushplay @JimiC @steffenvv @forivall @ExE-Boss @Aankhen @bcoe — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

Re-ping @poelstra, @mizunashi-mana, @pushplay, @JimiC, @steffenvv, @ExE-Boss, @Aankhen, @bcoe:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[forivall]

LGTM! sorry for the delay.

[typescript-bot]

⏳ Hi @wemeetagain,

It's been a few days since this PR was approved by jakebailey, forivall and we're waiting for a DT maintainer to give a review.

If you would like to short-circuit this wait, you can edit some of the test files in the package which verify how the .d.ts files work. This would allow the PR to be merged by you or the DT module owners after a re-review.

[typescript-bot]

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @wemeetagain.

(Ping @poelstra, @mizunashi-mana, @pushplay, @JimiC, @steffenvv, @ExE-Boss, @Aankhen, @bcoe.)

[typescript-bot]

Re-ping @wemeetagain / @poelstra, @mizunashi-mana, @pushplay, @JimiC, @steffenvv, @ExE-Boss, @Aankhen, @bcoe:

This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Apr 12th (in three weeks) if this doesn't happen.

(If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.)

[typescript-bot]

After a month, no one has requested merging the PR 😞. I'm going to assume that the change is not wanted after all, and will therefore close it.

[Aankhen]

I think I missed something here—@wemeetagain, did you decide not to merge it after all?